Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 11962003: Update git-lkgr with --create and --name options. (Closed)

Created:
7 years, 11 months ago by scheib
Modified:
7 years, 11 months ago
Reviewers:
Dirk Pranke, szager1
CC:
chromium-reviews, Dirk Pranke, cmp+cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org
Visibility:
Public.

Description

Update git-lkgr with --create and --name options. The previous --force-branch option is renamed --checkout (the old name preserved for backwards compatibility). Usage: --checkout Create a branch and check it out. --create Create a branch. -n, --name <name> Specify the name of branch to create or reset. This will force the branch using 'git branch -f '. -q, --quiet Quiet. NOTRY=true Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=177286

Patch Set 1 : consistent auto named branch #

Total comments: 2

Patch Set 2 : Handle needing to checkout and run deps2git... #

Patch Set 3 : merge TOT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -22 lines) Patch
M git-lkgr View 1 2 6 chunks +58 lines, -22 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
scheib
7 years, 11 months ago (2013-01-15 23:55:48 UTC) #1
szager1
https://codereview.chromium.org/11962003/diff/6001/git-lkgr File git-lkgr (right): https://codereview.chromium.org/11962003/diff/6001/git-lkgr#newcode124 git-lkgr:124: elif [ "${checkout_branch}" = "no" ]; then elif [ ...
7 years, 11 months ago (2013-01-16 00:46:05 UTC) #2
scheib
Please take another look. https://codereview.chromium.org/11962003/diff/6001/git-lkgr File git-lkgr (right): https://codereview.chromium.org/11962003/diff/6001/git-lkgr#newcode124 git-lkgr:124: elif [ "${checkout_branch}" = "no" ...
7 years, 11 months ago (2013-01-16 21:26:56 UTC) #3
szager1
lgtm, but needs rebase.
7 years, 11 months ago (2013-01-16 22:10:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scheib@chromium.org/11962003/13001
7 years, 11 months ago (2013-01-16 23:17:01 UTC) #5
commit-bot: I haz the power
Presubmit check for 11962003-13001 failed and returned exit status 1. Running presubmit commit checks ...
7 years, 11 months ago (2013-01-16 23:19:15 UTC) #6
scheib
dpranke, owners check please
7 years, 11 months ago (2013-01-16 23:28:13 UTC) #7
Dirk Pranke
As discussed in person, I feel like this command (like pretty much all git commands) ...
7 years, 11 months ago (2013-01-17 00:12:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scheib@chromium.org/11962003/13001
7 years, 11 months ago (2013-01-17 00:27:34 UTC) #9
commit-bot: I haz the power
7 years, 11 months ago (2013-01-17 00:29:49 UTC) #10
Message was sent while issue was closed.
Change committed as 177286

Powered by Google App Engine
This is Rietveld 408576698