Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 11961021: base: Convert scoped_arrays to the new scoped_ptr style. (Closed)

Created:
7 years, 11 months ago by tfarina
Modified:
7 years, 11 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org, sail+watch_chromium.org, jshin+watch_chromium.org
Visibility:
Public.

Description

base: Convert scoped_arrays to the new scoped_ptr style. BUG=109874 R=darin@chromium.org,ajwong@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177670

Patch Set 1 #

Total comments: 2

Patch Set 2 : revert callback changes #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -27 lines) Patch
M base/environment.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/file_util_proxy.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/i18n/icu_string_conversions.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M base/linux_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/md5_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/nix/mime_util_xdg.cc View 1 chunk +1 line, -1 line 1 comment Download
M base/pickle_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M base/process_util_posix.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M base/process_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/process_util_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/security_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/shared_memory_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M base/synchronization/condition_variable_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/win/enum_variant.h View 1 chunk +1 line, -1 line 0 comments Download
M base/win/win_util.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
tfarina
7 years, 11 months ago (2013-01-16 18:52:04 UTC) #1
awong
most mechanical changes look okay with the exception of callback_internal.h https://codereview.chromium.org/11961021/diff/1/base/callback_internal.h File base/callback_internal.h (right): https://codereview.chromium.org/11961021/diff/1/base/callback_internal.h#newcode140 ...
7 years, 11 months ago (2013-01-16 18:56:06 UTC) #2
tfarina
https://codereview.chromium.org/11961021/diff/1/base/callback_internal.h File base/callback_internal.h (right): https://codereview.chromium.org/11961021/diff/1/base/callback_internal.h#newcode140 base/callback_internal.h:140: struct CallbackParamTraits<scoped_ptr<T[]> > { On 2013/01/16 18:56:06, awong wrote: ...
7 years, 11 months ago (2013-01-16 19:00:28 UTC) #3
awong
LGTM
7 years, 11 months ago (2013-01-16 19:55:31 UTC) #4
darin (slow to review)
LGTM
7 years, 11 months ago (2013-01-16 22:33:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/11961021/4002
7 years, 11 months ago (2013-01-18 12:15:40 UTC) #6
commit-bot: I haz the power
Change committed as 177670
7 years, 11 months ago (2013-01-18 14:22:00 UTC) #7
dcheng
7 years, 11 months ago (2013-01-20 01:47:21 UTC) #8
Message was sent while issue was closed.
https://codereview.chromium.org/11961021/diff/4002/base/nix/mime_util_xdg.cc
File base/nix/mime_util_xdg.cc (right):

https://codereview.chromium.org/11961021/diff/4002/base/nix/mime_util_xdg.cc#...
base/nix/mime_util_xdg.cc:163: scoped_ptr<SubDirInfo[]> info_array_;  // List of
sub-directories.
FYI, there are some issues we still need to resolve with scoped_ptr<T[]>. To
reduce the amount of work to resolve these issues, please hold off on making
more patches removing scoped_array for now (in this case, crbug.com/171118 is
relevant)

Powered by Google App Engine
This is Rietveld 408576698