Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11959042: bookmarks: Forward declare some classes in header files when possible. (Closed)

Created:
7 years, 11 months ago by tfarina
Modified:
7 years, 11 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, browser-components-watch_chromium.org
Visibility:
Public.

Description

bookmarks: Forward declare some classes in header files when possible. BUG=144783 TBR=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177885

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M chrome/browser/bookmarks/bookmark_storage.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_storage.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/bookmarks/recently_used_folders_combo_model.h View 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/browser/bookmarks/recently_used_folders_combo_model_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
tfarina
TBRing...
7 years, 11 months ago (2013-01-19 13:55:12 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/11959042/1001
7 years, 11 months ago (2013-01-19 13:55:32 UTC) #2
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=75876
7 years, 11 months ago (2013-01-19 16:21:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/11959042/1001
7 years, 11 months ago (2013-01-19 16:35:36 UTC) #4
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=75888
7 years, 11 months ago (2013-01-19 18:46:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/11959042/1001
7 years, 11 months ago (2013-01-19 19:34:10 UTC) #6
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=75901
7 years, 11 months ago (2013-01-19 21:29:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/11959042/1001
7 years, 11 months ago (2013-01-20 00:39:26 UTC) #8
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=75925
7 years, 11 months ago (2013-01-20 02:40:42 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/11959042/1001
7 years, 11 months ago (2013-01-20 03:13:47 UTC) #10
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=75934
7 years, 11 months ago (2013-01-20 04:49:26 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/11959042/1001
7 years, 11 months ago (2013-01-20 12:32:28 UTC) #12
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=75959
7 years, 11 months ago (2013-01-20 14:55:00 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/11959042/1001
7 years, 11 months ago (2013-01-20 22:50:55 UTC) #14
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=75988
7 years, 11 months ago (2013-01-21 00:53:48 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/11959042/1001
7 years, 11 months ago (2013-01-21 02:01:50 UTC) #16
commit-bot: I haz the power
7 years, 11 months ago (2013-01-21 03:20:50 UTC) #17
Message was sent while issue was closed. 
Change committed as 177885

Powered by Google App Engine
This is Rietveld 408576698