src/api.cc - Issue 11959031: Add a new weak handle callback that passes an Isolate to an embedder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/api.cc

Issue 11959031: Add a new weak handle callback that passes an Isolate to an embedder (Closed) Base URL: git://github.com/v8/v8.git@master

Patch Set: Applied sven's comments Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/api.cc

diff --git a/src/api.cc b/src/api.cc

index 54b233c2f5ff9931fd94291b42e91efc4239ce2b..62d127cffc38b11d8c6908a220ae9b092d714158 100644

--- a/src/api.cc

+++ b/src/api.cc

@@ -646,7 +646,7 @@ void V8::MakeWeak(i::Object** object, void* parameters,

void V8::MakeWeak(i::Isolate* isolate, i::Object** object,

- void* parameters, WeakReferenceCallback callback) {

+ void* parameters, WeakHandleCallback callback) {

ASSERT(isolate == i::Isolate::Current());

LOG_API(isolate, "MakeWeak");

isolate->global_handles()->MakeWeak(object, parameters,

« no previous file with comments | « include/v8.h ('k') | src/global-handles.h » ('j') | no next file with comments »