Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1095)

Unified Diff: test/cctest/test-api.cc

Issue 11959031: Add a new weak handle callback that passes an Isolate to an embedder (Closed) Base URL: git://github.com/v8/v8.git@master
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/global-handles.cc ('K') | « src/global-handles.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-api.cc
diff --git a/test/cctest/test-api.cc b/test/cctest/test-api.cc
index dbde26f1a19ded9a2418b6c35115d90e2501c1ba..c88c6acaf56831eca374f4eeb4b5e25bf3107ea9 100644
--- a/test/cctest/test-api.cc
+++ b/test/cctest/test-api.cc
@@ -5549,7 +5549,8 @@ THREADED_TEST(WeakReference) {
}
-static void DisposeAndSetFlag(v8::Persistent<v8::Value> obj, void* data) {
+static void DisposeAndSetFlag(v8::Isolate* isolate,
+ v8::Persistent<v8::Value> obj, void* data) {
obj.Dispose();
obj.Clear();
*(reinterpret_cast<bool*>(data)) = true;
@@ -5571,8 +5572,8 @@ THREADED_TEST(IndependentWeakHandle) {
v8::Isolate* isolate = v8::Isolate::GetCurrent();
bool object_a_disposed = false;
bool object_b_disposed = false;
- object_a.MakeWeak(&object_a_disposed, &DisposeAndSetFlag);
- object_b.MakeWeak(&object_b_disposed, &DisposeAndSetFlag);
+ object_a.Weaken(isolate, &object_a_disposed, &DisposeAndSetFlag);
+ object_b.Weaken(isolate, &object_b_disposed, &DisposeAndSetFlag);
CHECK(!object_a.IsIndependent());
CHECK(!object_b.IsIndependent(isolate));
object_a.MarkIndependent();
« src/global-handles.cc ('K') | « src/global-handles.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698