Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1480)

Unified Diff: net/proxy/proxy_resolver_v8_unittest.cc

Issue 11959029: Make the v8 Isolate used in the proxy resolver explicit. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed component build Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/proxy/proxy_resolver_v8_unittest.cc
diff --git a/net/proxy/proxy_resolver_v8_unittest.cc b/net/proxy/proxy_resolver_v8_unittest.cc
index b93d4f3e43fe16d0fc0afa2d2b905acf1fb5cbed..22ee253178773573dcd5be4fc41c6ba819bcb550 100644
--- a/net/proxy/proxy_resolver_v8_unittest.cc
+++ b/net/proxy/proxy_resolver_v8_unittest.cc
@@ -15,6 +15,7 @@
#include "net/proxy/proxy_resolver_js_bindings.h"
#include "net/proxy/proxy_resolver_v8.h"
#include "testing/gtest/include/gtest/gtest.h"
+#include "v8/include/v8.h"
namespace net {
namespace {
@@ -88,7 +89,8 @@ class MockJSBindings : public ProxyResolverJSBindings {
// disk.
class ProxyResolverV8WithMockBindings : public ProxyResolverV8 {
public:
- ProxyResolverV8WithMockBindings() : ProxyResolverV8(new MockJSBindings()) {}
+ ProxyResolverV8WithMockBindings()
+ : ProxyResolverV8(new MockJSBindings(), v8::Isolate::GetCurrent()) {}
MockJSBindings* mock_js_bindings() const {
return reinterpret_cast<MockJSBindings*>(js_bindings());

Powered by Google App Engine
This is Rietveld 408576698