Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4783)

Unified Diff: chrome/browser/net/connection_tester_unittest.cc

Issue 11959029: Make the v8 Isolate used in the proxy resolver explicit. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed component build Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/net/connection_tester_unittest.cc
diff --git a/chrome/browser/net/connection_tester_unittest.cc b/chrome/browser/net/connection_tester_unittest.cc
index 5dd61c16d6b39404c71ae471e8cdc18873a528d0..c232e56d37234abe0b4b34ec61729b3c2fac5df1 100644
--- a/chrome/browser/net/connection_tester_unittest.cc
+++ b/chrome/browser/net/connection_tester_unittest.cc
@@ -21,6 +21,7 @@
#include "net/url_request/url_request_context.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "testing/platform_test.h"
+#include "v8/include/v8.h"
using content::BrowserThread;
@@ -150,7 +151,8 @@ TEST_F(ConnectionTesterTest, RunAllTests) {
ConnectionTester tester(&test_delegate_,
proxy_script_fetcher_context_.get(),
- NULL);
+ NULL,
+ v8::Isolate::GetCurrent());
// Start the test suite on URL "echoall".
// TODO(eroman): Is this URL right?
@@ -177,7 +179,8 @@ TEST_F(ConnectionTesterTest, DeleteWhileInProgress) {
scoped_ptr<ConnectionTester> tester(
new ConnectionTester(&test_delegate_,
proxy_script_fetcher_context_.get(),
- NULL));
+ NULL,
+ v8::Isolate::GetCurrent()));
// Start the test suite on URL "echoall".
// TODO(eroman): Is this URL right?

Powered by Google App Engine
This is Rietveld 408576698