Remove some unnecessary use of templates.

src/api.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 4163 matching lines @@
     buffer[i] = c;
   }
   if (!(options & NO_NULL_TERMINATION) && (length == -1 || i < length)) {
     buffer[i] = '\0';
   }
   return i;
 }
 
 
 template<typename CharType>
-struct WriteHelper {
-  static inline int Write(const String* string,
-                          CharType* buffer,
-                          int start,
-                          int length,
-                          int options) {
-    i::Isolate* isolate = Utils::OpenHandle(string)->GetIsolate();
-    if (IsDeadCheck(isolate, "v8::String::Write()")) return 0;
-    LOG_API(isolate, "String::Write");
-    ENTER_V8(isolate);
-    ASSERT(start >= 0 && length >= -1);
-    i::Handle<i::String> str = Utils::OpenHandle(string);
-    isolate->string_tracker()->RecordWrite(str);
-    if (options & String::HINT_MANY_WRITES_EXPECTED) {
-      // Flatten the string for efficiency.  This applies whether we are
-      // using StringCharacterStream or Get(i) to access the characters.
-      FlattenString(str);
-    }
-    int end = start + length;
-    if ((length == -1) || (length > str->length() - start) )
-      end = str->length();
-    if (end < 0) return 0;
-    i::String::WriteToFlat(*str, buffer, start, end);
-    if (!(options & String::NO_NULL_TERMINATION) &&
-        (length == -1 || end - start < length)) {
-      buffer[end - start] = '\0';
-    }
-    return end - start;
+static inline int WriteHelper(const String* string,
+                              CharType* buffer,
+                              int start,
+                              int length,
+                              int options) {
+  i::Isolate* isolate = Utils::OpenHandle(string)->GetIsolate();
+  if (IsDeadCheck(isolate, "v8::String::Write()")) return 0;
+  LOG_API(isolate, "String::Write");
+  ENTER_V8(isolate);
+  ASSERT(start >= 0 && length >= -1);
+  i::Handle<i::String> str = Utils::OpenHandle(string);
+  isolate->string_tracker()->RecordWrite(str);
+  if (options & String::HINT_MANY_WRITES_EXPECTED) {
+    // Flatten the string for efficiency.  This applies whether we are
+    // using StringCharacterStream or Get(i) to access the characters.
+    FlattenString(str);
   }
-};
+  int end = start + length;
+  if ((length == -1) || (length > str->length() - start) )
+    end = str->length();
+  if (end < 0) return 0;
+  i::String::WriteToFlat(*str, buffer, start, end);
+  if (!(options & String::NO_NULL_TERMINATION) &&
+      (length == -1 || end - start < length)) {
+    buffer[end - start] = '\0';
+  }
+  return end - start;
+}
 
 
 int String::WriteOneByte(uint8_t* buffer,
                          int start,
                          int length,
                          int options) const {
-  return WriteHelper<uint8_t>::Write(this, buffer, start, length, options);
+  return WriteHelper(this, buffer, start, length, options);
 }
 
 
 int String::Write(uint16_t* buffer,
                   int start,
                   int length,
                   int options) const {
-  return WriteHelper<uint16_t>::Write(this, buffer, start, length, options);
+  return WriteHelper(this, buffer, start, length, options);
 }
 
 
 bool v8::String::IsExternal() const {
   i::Handle<i::String> str = Utils::OpenHandle(this);
   if (IsDeadCheck(str->GetIsolate(), "v8::String::IsExternal()")) {
     return false;
   }
   EnsureInitializedForIsolate(str->GetIsolate(), "v8::String::IsExternal()");
   return i::StringShape(*str).IsExternalTwoByte();
@@ skipping 2502 matching lines @@
 
   v->VisitPointers(blocks_.first(), first_block_limit_);
 
   for (int i = 1; i < blocks_.length(); i++) {
     v->VisitPointers(blocks_[i], &blocks_[i][kHandleBlockSize]);
   }
 }
 
 
 } }  // namespace v8::internal