Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: webkit/plugins/ppapi/file_callbacks.cc

Issue 11958033: Implement Pepper proxy for PPB_DirectoryReader (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: test fix Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/plugins/ppapi/file_callbacks.h ('k') | webkit/plugins/ppapi/plugin_module.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/plugins/ppapi/file_callbacks.cc
diff --git a/webkit/plugins/ppapi/file_callbacks.cc b/webkit/plugins/ppapi/file_callbacks.cc
index dd8906d28ff8a4a84ac451fb4c87cbc93ebcb81c..5582d393a9e1d7294c6d47d63e42ce8ed537b538 100644
--- a/webkit/plugins/ppapi/file_callbacks.cc
+++ b/webkit/plugins/ppapi/file_callbacks.cc
@@ -13,7 +13,6 @@
#include "ppapi/shared_impl/tracked_callback.h"
#include "webkit/fileapi/file_system_types.h"
#include "webkit/plugins/ppapi/plugin_module.h"
-#include "webkit/plugins/ppapi/ppb_directory_reader_impl.h"
#include "webkit/plugins/ppapi/ppb_file_system_impl.h"
using ppapi::Resource;
@@ -27,12 +26,10 @@ FileCallbacks::FileCallbacks(
Resource* resource,
scoped_refptr<TrackedCallback> callback,
PP_FileInfo* info,
- scoped_refptr<PPB_FileSystem_Impl> file_system,
- scoped_refptr<PPB_DirectoryReader_Impl> directory_reader)
+ scoped_refptr<PPB_FileSystem_Impl> file_system)
: callback_(callback),
info_(info),
- file_system_(file_system),
- directory_reader_(directory_reader) {
+ file_system_(file_system) {
}
FileCallbacks::~FileCallbacks() {}
@@ -67,13 +64,7 @@ void FileCallbacks::DidReadMetadata(
void FileCallbacks::DidReadDirectory(
const std::vector<base::FileUtilProxy::Entry>& entries, bool has_more) {
- if (callback_->completed())
- return;
-
- DCHECK(directory_reader_);
- directory_reader_->AddNewEntries(entries, has_more);
-
- callback_->Run(PP_OK);
+ NOTREACHED();
}
void FileCallbacks::DidOpenFileSystem(const std::string&,
« no previous file with comments | « webkit/plugins/ppapi/file_callbacks.h ('k') | webkit/plugins/ppapi/plugin_module.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698