Stubbing out the initial library for Chrome application support.

Stubbing out the initial library for Chrome application support.

This adds the core skeleton of Chrome application support with a sample function that allows creating a new window (in dart2js).

BUG=

Committed: https://code.google.com/p/dart/source/detail?r=17299

[sashab, 2013-01-17 02:56:17]

Works with the following sample app:


import 'dart:chrome' as chrome;

void main() {
 chrome.app.window.create('chrome_app.html');
}


Works as a chrome app and actually opens the window required.

[sashab, 2013-01-17 02:56:47]

https://codereview.chromium.org/11958026/diff/7001/sdk/lib/chrome/dart2js/chr...
File sdk/lib/chrome/dart2js/chrome_dart2js.dart (right):

https://codereview.chromium.org/11958026/diff/7001/sdk/lib/chrome/dart2js/chr...
sdk/lib/chrome/dart2js/chrome_dart2js.dart:21: JS('void',
'chrome.app.window.create(#)');
Should be
  JS('void', 'chrome.app.window.create(#)', url);

This will be overwritten later anyway.

[vsm, 2013-01-17 15:31:28]

lgtm!

https://codereview.chromium.org/11958026/diff/7001/tools/dom/src/chrome/sampl...
File tools/dom/src/chrome/sample.dart (right):

https://codereview.chromium.org/11958026/diff/7001/tools/dom/src/chrome/sampl...
tools/dom/src/chrome/sample.dart:8: class ChromeApp {
Internal constructor for this class ala ChromeWindow below?

https://codereview.chromium.org/11958026/diff/7001/tools/dom/src/chrome/sampl...
tools/dom/src/chrome/sample.dart:12: class ChromeWindow {
Since chrome.app.window is a module and not an actual window, I'd be tempted to
name this class differently.  E.g., WindowModule?

[blois, 2013-01-17 18:03:20]

https://codereview.chromium.org/11958026/diff/7001/sdk/lib/chrome/dart2js/chr...
File sdk/lib/chrome/dart2js/chrome_dart2js.dart (right):

https://codereview.chromium.org/11958026/diff/7001/sdk/lib/chrome/dart2js/chr...
sdk/lib/chrome/dart2js/chrome_dart2js.dart:21: JS('void',
'chrome.app.window.create(#)');
On 2013/01/17 02:56:47, sasha_b wrote:
> Should be
>   JS('void', 'chrome.app.window.create(#)', url);
> 
> This will be overwritten later anyway.

Yeah, dunno what happened to that- I had it working!

https://codereview.chromium.org/11958026/diff/7001/tools/dom/src/chrome/sampl...
File tools/dom/src/chrome/sample.dart (right):

https://codereview.chromium.org/11958026/diff/7001/tools/dom/src/chrome/sampl...
tools/dom/src/chrome/sample.dart:8: class ChromeApp {
On 2013/01/17 15:31:28, vsm wrote:
> Internal constructor for this class ala ChromeWindow below?

Done.

https://codereview.chromium.org/11958026/diff/7001/tools/dom/src/chrome/sampl...
tools/dom/src/chrome/sample.dart:12: class ChromeWindow {
On 2013/01/17 15:31:28, vsm wrote:
> Since chrome.app.window is a module and not an actual window, I'd be tempted
to
> name this class differently.  E.g., WindowModule?

Done.

In general I'm not quite sure of the nicest way to expose these APIs- this
follows the JS syntax, but it's not exactly 'darty'. But all this will get
replaced.

[blois, 2013-01-17 18:04:07]

+ngeoffray & ahe for compiler changes.

[ahe, 2013-01-17 18:41:27]

Please add a test.

https://codereview.chromium.org/11958026/diff/9002/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/native_handler.dart (right):

https://codereview.chromium.org/11958026/diff/9002/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/native_handler.dart:458: ||
libraryName == 'dart:chrome'
Why do you need this?

https://codereview.chromium.org/11958026/diff/9002/sdk/lib/chrome/dart2js/chr...
File sdk/lib/chrome/dart2js/chrome_dart2js.dart (right):

https://codereview.chromium.org/11958026/diff/9002/sdk/lib/chrome/dart2js/chr...
sdk/lib/chrome/dart2js/chrome_dart2js.dart:7: // Copyright (c) 2012, the Dart
project authors.  Please see the AUTHORS file
I think the copyright needs to go in the beginning of the file.

https://codereview.chromium.org/11958026/diff/9002/sdk/lib/chrome/dart2js/chr...
sdk/lib/chrome/dart2js/chrome_dart2js.dart:13: class AppModule {
This class is not documented.

https://codereview.chromium.org/11958026/diff/9002/sdk/lib/chrome/dart2js/chr...
sdk/lib/chrome/dart2js/chrome_dart2js.dart:19: class WindowModule {
This class is not documented.

https://codereview.chromium.org/11958026/diff/9002/sdk/lib/chrome/dart2js/chr...
sdk/lib/chrome/dart2js/chrome_dart2js.dart:23: JS('void',
'chrome.app.window.create(#)', url);
I think this should be:

var chrome = JS('', 'chrome');
if (chrome == null) throw new UnsupportedError('explanation');
var app = JS('', '#.app', chrome);
if (app == null) throw new UnsupportedError('explanation');
...

[blois, 2013-01-17 21:03:30]

https://codereview.chromium.org/11958026/diff/9002/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/native_handler.dart (right):

https://codereview.chromium.org/11958026/diff/9002/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/native_handler.dart:458: ||
libraryName == 'dart:chrome'
On 2013/01/17 18:41:27, ahe wrote:
> Why do you need this?

I was under the impression that this is required for the 'native' keyword.

The goal is for dart:chrome to be generated identically to
dart:html/indexed_db/svg/web_audio, so I'm assuming that it needs the same
access.

Basically the chrome application APIs use a different IDL format than the rest
of the APIs, and Sasha is going to be working on supporting those.

https://codereview.chromium.org/11958026/diff/9002/sdk/lib/chrome/dart2js/chr...
File sdk/lib/chrome/dart2js/chrome_dart2js.dart (right):

https://codereview.chromium.org/11958026/diff/9002/sdk/lib/chrome/dart2js/chr...
sdk/lib/chrome/dart2js/chrome_dart2js.dart:7: // Copyright (c) 2012, the Dart
project authors.  Please see the AUTHORS file
On 2013/01/17 18:41:27, ahe wrote:
> I think the copyright needs to go in the beginning of the file.

Done.

Though note that the copyright is still preceeded by library chrome as a
by-product of our code gen process. This is no different than the rest of our
libs.

https://codereview.chromium.org/11958026/diff/9002/sdk/lib/chrome/dart2js/chr...
sdk/lib/chrome/dart2js/chrome_dart2js.dart:13: class AppModule {
On 2013/01/17 18:41:27, ahe wrote:
> This class is not documented.

This is placeholder code which will be deleted. The purpose of this CL is to get
the lib set up for Sasha, who will then work on exposing the chrome app APIs.

Added a comment to the file to this extent.

https://codereview.chromium.org/11958026/diff/9002/sdk/lib/chrome/dart2js/chr...
sdk/lib/chrome/dart2js/chrome_dart2js.dart:19: class WindowModule {
On 2013/01/17 18:41:27, ahe wrote:
> This class is not documented.

Ditto, this will be removed.

https://codereview.chromium.org/11958026/diff/9002/sdk/lib/chrome/dart2js/chr...
sdk/lib/chrome/dart2js/chrome_dart2js.dart:23: JS('void',
'chrome.app.window.create(#)', url);
On 2013/01/17 18:41:27, ahe wrote:
> I think this should be:
> 
> var chrome = JS('', 'chrome');
> if (chrome == null) throw new UnsupportedError('explanation');
> var app = JS('', '#.app', chrome);
> if (app == null) throw new UnsupportedError('explanation');
> ...

Done.

[ahe, 2013-01-17 22:06:55]

https://codereview.chromium.org/11958026/diff/9002/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/native_handler.dart (right):

https://codereview.chromium.org/11958026/diff/9002/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/native_handler.dart:458: ||
libraryName == 'dart:chrome'
On 2013/01/17 21:03:30, blois wrote:
> On 2013/01/17 18:41:27, ahe wrote:
> > Why do you need this?
> 
> I was under the impression that this is required for the 'native' keyword.
> 
> The goal is for dart:chrome to be generated identically to
> dart:html/indexed_db/svg/web_audio, so I'm assuming that it needs the same
> access.
> 
> Basically the chrome application APIs use a different IDL format than the rest
> of the APIs, and Sasha is going to be working on supporting those.

I think this is different from dart:html, etc.

As it is right now, I do not think it is safe to use the native keyword in this
library, and I'm concerned that doing so may conflict with the other APIs.

Unless you have strong evidence that wrapping is not going to work, I'd really
prefer if you do not enable the native keyword in this library.

[ahe, 2013-01-18 12:52:15]

Compiler changes, LGTM!

https://codereview.chromium.org/11958026/diff/18001/sdk/lib/chrome/dart2js/ch...
File sdk/lib/chrome/dart2js/chrome_dart2js.dart (right):

https://codereview.chromium.org/11958026/diff/18001/sdk/lib/chrome/dart2js/ch...
sdk/lib/chrome/dart2js/chrome_dart2js.dart:37: }
You could move the above checks to the AppModule class' constructor, and pass in
app as a final field to this class.

https://codereview.chromium.org/11958026/diff/18001/sdk/lib/chrome/dart2js/ch...
sdk/lib/chrome/dart2js/chrome_dart2js.dart:41: }
You might want to check this in the constructor of this class.