Issue 11958011: Add missing VMState(EXTERNAL) for DOM GC callbacks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11958011: Add missing VMState(EXTERNAL) for DOM GC callbacks (Closed)

Created:
7 years, 11 months ago by haraken

Modified:
7 years, 11 months ago

Reviewers:
Yang, danno

Base URL:
git://github.com/v8/v8.git@master

Visibility:
Public.

More Reviews

Description

Add missing VMState(EXTERNAL) for DOM GC callbacks BUG= Committed: https://code.google.com/p/v8/source/detail?r=13403

Patch Set 1 #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	src/heap.cc	View		4 chunks	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

haraken

In the current V8 timeline plot, the time spent in DOM GC callbacks (it can ...

7 years, 11 months ago (2013-01-16 15:10:55 UTC) #1

Yang

7 years, 11 months ago (2013-01-16 15:15:25 UTC) #2

On 2013/01/16 15:10:55, haraken1 wrote:
> In the current V8 timeline plot, the time spent in DOM GC callbacks (it can
> consume a substantial amount of time) is not counted as EXTERNAL time.
> 
> yang: Could you review it?

LGTM. Landing.

Expand Messages | Collapse Messages