Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Unified Diff: content/browser/devtools/devtools_tracing_handler.h

Issue 11958010: DevTools: brush up remote debugging browser target: use callbacks, make handlers implementation a m… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Review comments addressed (left error handling order in place) Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/devtools_tracing_handler.h
diff --git a/content/browser/devtools/devtools_tracing_handler.h b/content/browser/devtools/devtools_tracing_handler.h
index 9cca19b56cf685cd1d191a81708385cfbacd0f19..75dea1fee121bc05003b101a3eb87fb9433249fa 100644
--- a/content/browser/devtools/devtools_tracing_handler.h
+++ b/content/browser/devtools/devtools_tracing_handler.h
@@ -16,7 +16,7 @@ class DevToolsWebSocketSender;
// infrastructure.
class DevToolsTracingHandler
: public TraceSubscriber,
- public DevToolsBrowserTarget::Handler {
+ public DevToolsBrowserTarget::DomainHandler {
public:
DevToolsTracingHandler();
virtual ~DevToolsTracingHandler();
@@ -26,17 +26,11 @@ class DevToolsTracingHandler
virtual void OnTraceDataCollected(
const scoped_refptr<base::RefCountedString>& trace_fragment) OVERRIDE;
- // DevToolBrowserTarget::Handler:
- virtual std::string Domain() OVERRIDE;
- virtual base::Value* OnProtocolCommand(
- const std::string& method,
- const base::DictionaryValue* params,
- base::Value** error_out) OVERRIDE;
-
private:
- base::Value* Start(const base::DictionaryValue* params);
- base::Value* End(const base::DictionaryValue* params);
- void SendNotification(const std::string& method, const std::string& value);
+ base::DictionaryValue* OnStart(const base::DictionaryValue* params,
+ base::Value** error_out);
+ base::DictionaryValue* OnEnd(const base::DictionaryValue* params,
+ base::Value** error_out);
bool is_running_;
« no previous file with comments | « content/browser/devtools/devtools_http_handler_impl.cc ('k') | content/browser/devtools/devtools_tracing_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698