Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2709)

Unified Diff: content/renderer/browser_plugin/mock_browser_plugin_manager.cc

Issue 11956022: Browser Plugin: Allocate Instance IDs in BrowserPluginEmbedder instead of BrowserPluginManager (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merged with ToT Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/browser_plugin/mock_browser_plugin_manager.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/browser_plugin/mock_browser_plugin_manager.cc
diff --git a/content/renderer/browser_plugin/mock_browser_plugin_manager.cc b/content/renderer/browser_plugin/mock_browser_plugin_manager.cc
index da8541fa0c5ec4f6fd4c3f48f0909bd3f8075b7b..fdea06b056fdad7edb7f4a3a1d36c59f92c4159e 100644
--- a/content/renderer/browser_plugin/mock_browser_plugin_manager.cc
+++ b/content/renderer/browser_plugin/mock_browser_plugin_manager.cc
@@ -4,14 +4,17 @@
#include "content/renderer/browser_plugin/mock_browser_plugin_manager.h"
-#include "ipc/ipc_message.h"
+#include "base/message_loop.h"
+#include "content/common/browser_plugin_messages.h"
#include "content/renderer/browser_plugin/mock_browser_plugin.h"
+#include "ipc/ipc_message.h"
namespace content {
MockBrowserPluginManager::MockBrowserPluginManager(
RenderViewImpl* render_view)
- : BrowserPluginManager(render_view) {
+ : BrowserPluginManager(render_view),
+ browser_plugin_counter_(0) {
}
MockBrowserPluginManager::~MockBrowserPluginManager() {
@@ -21,10 +24,24 @@ BrowserPlugin* MockBrowserPluginManager::CreateBrowserPlugin(
RenderViewImpl* render_view,
WebKit::WebFrame* frame,
const WebKit::WebPluginParams& params) {
- return new MockBrowserPlugin(++browser_plugin_counter_,
- render_view,
- frame,
- params);
+ return new MockBrowserPlugin(render_view, frame, params);
+}
+
+void MockBrowserPluginManager::AllocateInstanceID(
+ BrowserPlugin* browser_plugin) {
+ int instance_id = ++browser_plugin_counter_;
+ MessageLoop::current()->PostTask(
+ FROM_HERE,
+ base::Bind(&MockBrowserPluginManager::AllocateInstanceIDACK,
+ this,
+ base::Unretained(browser_plugin),
+ instance_id));
+}
+
+void MockBrowserPluginManager::AllocateInstanceIDACK(
+ BrowserPlugin* browser_plugin,
+ int instance_id) {
+ browser_plugin->SetInstanceID(instance_id);
}
bool MockBrowserPluginManager::Send(IPC::Message* msg) {
« no previous file with comments | « content/renderer/browser_plugin/mock_browser_plugin_manager.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698