Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1889)

Unified Diff: content/renderer/browser_plugin/browser_plugin_manager.h

Issue 11956022: Browser Plugin: Allocate Instance IDs in BrowserPluginEmbedder instead of BrowserPluginManager (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merged with ToT Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/browser_plugin/browser_plugin_manager.h
diff --git a/content/renderer/browser_plugin/browser_plugin_manager.h b/content/renderer/browser_plugin/browser_plugin_manager.h
index 21f17fa1033771a4e5f2cf1775bf354bdd277a19..a4a59daf32058002b2c3b5c30c04b96fa4ab7f00 100644
--- a/content/renderer/browser_plugin/browser_plugin_manager.h
+++ b/content/renderer/browser_plugin/browser_plugin_manager.h
@@ -38,7 +38,7 @@ class CONTENT_EXPORT BrowserPluginManager
BrowserPluginManager::factory_ = factory;
}
- BrowserPluginManager(RenderViewImpl* render_view);
+ explicit BrowserPluginManager(RenderViewImpl* render_view);
// Creates a new BrowserPlugin object with a unique identifier.
// BrowserPlugin is responsible for associating itself with the
@@ -48,6 +48,7 @@ class CONTENT_EXPORT BrowserPluginManager
RenderViewImpl* render_view,
WebKit::WebFrame* frame,
const WebKit::WebPluginParams& params) = 0;
+ virtual void AllocateInstanceID(BrowserPlugin* browser_plugin) = 0;
void AddBrowserPlugin(int instance_id, BrowserPlugin* browser_plugin);
void RemoveBrowserPlugin(int instance_id);
@@ -76,7 +77,8 @@ class CONTENT_EXPORT BrowserPluginManager
virtual ~BrowserPluginManager();
IDMap<BrowserPlugin> instances_;
base::WeakPtr<RenderViewImpl> render_view_;
- int browser_plugin_counter_;
+
+ DISALLOW_COPY_AND_ASSIGN(BrowserPluginManager);
};
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698