Fix up how the JSON Schema compiler decides whether to include or forward

Fix up how the JSON Schema compiler decides whether to include or forward
declare references to C++ types in other files. This fixed up a problem where
references as part of required properties would cause compilation errors,
specifically for the use of tabs.InjectDetails from the webview API.


BUG=171726
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=179232

[Fady Samuel, 2013-01-25 22:35:22]

Awesome! Thanks! LGTM

[Yoyo Zhou, 2013-01-26 01:43:02]

LGTM with nits

https://codereview.chromium.org/11953121/diff/1/tools/json_schema_compiler/cp...
File tools/json_schema_compiler/cpp_type_generator.py (right):

https://codereview.chromium.org/11953121/diff/1/tools/json_schema_compiler/cp...
tools/json_schema_compiler/cpp_type_generator.py:233: hard=(not param.optional))
I think these parens are unnecessary.

https://codereview.chromium.org/11953121/diff/1/tools/json_schema_compiler/sc...
File tools/json_schema_compiler/schema_util.py (right):

https://codereview.chromium.org/11953121/diff/1/tools/json_schema_compiler/sc...
tools/json_schema_compiler/schema_util.py:19: """Returns (namespace, thing) from
|ref|. If |ref| isn't qualified then
Surely there's a better word than 'thing'.

[not at google - send to devlin, 2013-01-26 04:35:31]

There's unfortunately another problem with having the tabs API $ref'd to from
the webview API, which is making a test fail (WebViewTest.Shim to be exact) -
the tabs permission isn't available to platform apps, so they aren't getting the
tabs types pulled in.

I'll fix that problem next week then submit this. The options for that are
either to (a) always import $ref'd types regardless of permissions, but this
might be a bit of a yak, or (b) make it so that the tabs permission is
implicitly granted for webview, but this might also be a yak. I think (a) would
be a better general solution, but I'll think about it.

https://codereview.chromium.org/11953121/diff/1/tools/json_schema_compiler/cp...
File tools/json_schema_compiler/cpp_type_generator.py (right):

https://codereview.chromium.org/11953121/diff/1/tools/json_schema_compiler/cp...
tools/json_schema_compiler/cpp_type_generator.py:233: hard=(not param.optional))
On 2013/01/26 01:43:02, Yoyo Zhou wrote:
> I think these parens are unnecessary.

Done.

https://codereview.chromium.org/11953121/diff/1/tools/json_schema_compiler/sc...
File tools/json_schema_compiler/schema_util.py (right):

https://codereview.chromium.org/11953121/diff/1/tools/json_schema_compiler/sc...
tools/json_schema_compiler/schema_util.py:19: """Returns (namespace, thing) from
|ref|. If |ref| isn't qualified then
On 2013/01/26 01:43:02, Yoyo Zhou wrote:
> Surely there's a better word than 'thing'.

probably

[commit-bot: I haz the power, 2013-01-28 22:41:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kalman@chromium.org/11953121/16002

[commit-bot: I haz the power, 2013-01-29 00:56:29]

Change committed as 179232