Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 11953084: Browser Plugin: Removed spammy NOTIMPLEMENTED() messages in RWHVG/WCVG (Closed)

Created:
7 years, 11 months ago by Fady Samuel
Modified:
7 years, 11 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, James Su
Visibility:
Public.

Description

Browser Plugin: Removed spammy NOTIMPLEMENTED() messages in RenderWidgetHostViewGuest/WebContentsViewGuest. There are a lot of NOTIMPLEMENTED() messages in RenderWidgetHostViewGuest and WebContentsViewGuest and they come up really frequently to the point where they seem to add no value. I've removed all the ones I've seen pop up during regular browsing. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=178770

Patch Set 1 #

Patch Set 2 : Removed more NOTIMPLEMENTED() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -58 lines) Patch
M content/browser/renderer_host/render_widget_host_view_guest.cc View 1 6 chunks +0 lines, -50 lines 0 comments Download
M content/browser/web_contents/web_contents_view_guest.cc View 1 4 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Fady Samuel
7 years, 11 months ago (2013-01-24 18:17:53 UTC) #1
alexst (slow to review)
lgtm These were stubbed out to catch unexpected calls. We were too aggressive and these ...
7 years, 11 months ago (2013-01-24 18:23:49 UTC) #2
Fady Samuel
+jam@ for content OWNER approval.
7 years, 11 months ago (2013-01-24 18:26:27 UTC) #3
Fady Samuel
-jam@ who is OOO +creis@ for content OWNER approval.
7 years, 11 months ago (2013-01-25 01:42:00 UTC) #4
Charlie Reis
Why keep the rest? There doesn't seem to be a rhyme or reason to the ...
7 years, 11 months ago (2013-01-25 02:02:16 UTC) #5
Fady Samuel
PTAL. Removed more NOTIMPLEMENTED(). Only left behind those I expect will be implemented shortly.
7 years, 11 months ago (2013-01-25 02:26:26 UTC) #6
Charlie Reis
LGTM.
7 years, 11 months ago (2013-01-25 02:33:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/11953084/3002
7 years, 11 months ago (2013-01-25 02:38:23 UTC) #8
commit-bot: I haz the power
7 years, 11 months ago (2013-01-25 06:54:28 UTC) #9
Message was sent while issue was closed.
Change committed as 178770

Powered by Google App Engine
This is Rietveld 408576698