Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Unified Diff: ui/views/widget/widget_unittest.cc

Issue 11953066: Reland 179231 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix DesktopBackgroundView leak Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/views/widget/widget_delegate.cc ('k') | ui/views/window/dialog_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/widget/widget_unittest.cc
diff --git a/ui/views/widget/widget_unittest.cc b/ui/views/widget/widget_unittest.cc
index f42b877c86fee0eed3f0ed6a370a73d7680aecb5..6e6ed0717cab57c97ae4b684d4a8094e92ea1a27 100644
--- a/ui/views/widget/widget_unittest.cc
+++ b/ui/views/widget/widget_unittest.cc
@@ -827,6 +827,29 @@ TEST_F(WidgetOwnershipTest,
EXPECT_TRUE(state.native_widget_deleted);
}
+// Widget owns its NativeWidget and has a WidgetDelegateView as its contents.
+TEST_F(WidgetOwnershipTest,
+ Ownership_WidgetOwnsNativeWidgetWithWithWidgetDelegateView) {
+ OwnershipTestState state;
+
+ WidgetDelegateView* delegate_view = new WidgetDelegateView;
+
+ scoped_ptr<Widget> widget(new OwnershipTestWidget(&state));
+ Widget::InitParams params = CreateParams(Widget::InitParams::TYPE_POPUP);
+ params.native_widget =
+ new OwnershipTestNativeWidgetPlatform(widget.get(), &state);
+ params.ownership = Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET;
+ params.delegate = delegate_view;
+ widget->Init(params);
+ widget->SetContentsView(delegate_view);
+
+ // Now delete the Widget. There should be no crash or use-after-free.
+ widget.reset();
+
+ EXPECT_TRUE(state.widget_deleted);
+ EXPECT_TRUE(state.native_widget_deleted);
+}
+
////////////////////////////////////////////////////////////////////////////////
// Widget observer tests.
//
@@ -903,7 +926,6 @@ class WidgetObserverTest : public WidgetTest, public WidgetObserver {
const Widget* widget_bounds_changed() const { return widget_bounds_changed_; }
private:
-
Widget* active_;
Widget* widget_closed_;
« no previous file with comments | « ui/views/widget/widget_delegate.cc ('k') | ui/views/window/dialog_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698