Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 11953040: Add a scroll threshold/marker to control hiding/showing top controls. (Closed)

Created:
7 years, 11 months ago by Ted C
Modified:
7 years, 11 months ago
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

Add a scroll limit to control hiding/showing top controls. When starting a scroll gesture, mark a initial scroll marker and do not hide the top controls when above the marker and do not show the controls when below (further down the page) the threshold. BUG=161303 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=178749

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -7 lines) Patch
M cc/top_controls_manager.h View 1 chunk +2 lines, -1 line 0 comments Download
M cc/top_controls_manager.cc View 5 chunks +27 lines, -6 lines 0 comments Download
M cc/top_controls_manager_unittest.cc View 1 1 chunk +50 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Ted C
7 years, 11 months ago (2013-01-23 02:31:28 UTC) #1
David Trainor- moved to gerrit
lgtm
7 years, 11 months ago (2013-01-23 19:21:08 UTC) #2
Ted C
+james|enne - owners approval
7 years, 11 months ago (2013-01-24 17:47:45 UTC) #3
jamesr
lgtm https://codereview.chromium.org/11953040/diff/1/cc/top_controls_manager_unittest.cc File cc/top_controls_manager_unittest.cc (right): https://codereview.chromium.org/11953040/diff/1/cc/top_controls_manager_unittest.cc#newcode144 cc/top_controls_manager_unittest.cc:144: TEST(TopControlsManagerTest, enssureScrollThresholdApplied) { typo "enssure" -> "ensure"
7 years, 11 months ago (2013-01-24 22:05:28 UTC) #4
Ted C
https://codereview.chromium.org/11953040/diff/1/cc/top_controls_manager_unittest.cc File cc/top_controls_manager_unittest.cc (right): https://codereview.chromium.org/11953040/diff/1/cc/top_controls_manager_unittest.cc#newcode144 cc/top_controls_manager_unittest.cc:144: TEST(TopControlsManagerTest, enssureScrollThresholdApplied) { On 2013/01/24 22:05:29, jamesr wrote: > ...
7 years, 11 months ago (2013-01-24 23:56:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tedchoc@chromium.org/11953040/5001
7 years, 11 months ago (2013-01-24 23:57:29 UTC) #6
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=92743
7 years, 11 months ago (2013-01-25 02:32:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tedchoc@chromium.org/11953040/5001
7 years, 11 months ago (2013-01-25 03:08:50 UTC) #8
commit-bot: I haz the power
7 years, 11 months ago (2013-01-25 04:38:56 UTC) #9
Message was sent while issue was closed.
Change committed as 178749

Powered by Google App Engine
This is Rietveld 408576698