Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1136)

Issue 11953025: Move polymorphic stub computation and compilation to stub cache (Closed)

Created:
7 years, 11 months ago by Toon Verwaest
Modified:
7 years, 11 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Move polymorphic stub computation and compilation to stub cache Committed: https://code.google.com/p/v8/source/detail?r=13478

Patch Set 1 : Removed KeyedIC, KeyedLoad subclass Load, KeyedStore subclass Store #

Total comments: 2

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+432 lines, -505 lines) Patch
M src/ic.h View 13 chunks +88 lines, -188 lines 0 comments Download
M src/ic.cc View 1 12 chunks +179 lines, -258 lines 0 comments Download
M src/stub-cache.h View 4 chunks +17 lines, -3 lines 0 comments Download
M src/stub-cache.cc View 4 chunks +148 lines, -56 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Toon Verwaest
PTAL In this CL I first moved polymorphic cache handling to stub-cache, so that it ...
7 years, 11 months ago (2013-01-22 17:49:58 UTC) #1
Jakob Kummerow
LGTM. https://chromiumcodereview.appspot.com/11953025/diff/1005/src/ic.cc File src/ic.cc (right): https://chromiumcodereview.appspot.com/11953025/diff/1005/src/ic.cc#newcode1696 src/ic.cc:1696: case KeyedStoreIC::STORE_TRANSITION_SMI_TO_OBJECT: nit: since this is now a ...
7 years, 11 months ago (2013-01-23 13:55:06 UTC) #2
Toon Verwaest
7 years, 11 months ago (2013-01-23 15:35:58 UTC) #3
Message was sent while issue was closed.
Addressed comments,

https://chromiumcodereview.appspot.com/11953025/diff/1005/src/ic.cc
File src/ic.cc (right):

https://chromiumcodereview.appspot.com/11953025/diff/1005/src/ic.cc#newcode1696
src/ic.cc:1696: case KeyedStoreIC::STORE_TRANSITION_SMI_TO_OBJECT:
On 2013/01/23 13:55:06, Jakob wrote:
> nit: since this is now a method of KeyedStoreIC, you could also
> s/KeyedStoreIC:://. I don't care much either way.

Done.

Powered by Google App Engine
This is Rietveld 408576698