Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 11953003: Make printing build on Win64 (Closed)

Created:
7 years, 11 months ago by jschuh
Modified:
7 years, 11 months ago
Reviewers:
Lei Zhang, scottmg
CC:
chromium-reviews
Visibility:
Public.

Description

Make printing build on Win64 Just adds some safe casts for the integer conversions. BUG=166496 TBR=thestig@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177940

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -5 lines) Patch
M printing/image.cc View 3 chunks +5 lines, -2 lines 0 comments Download
M printing/pdf_metafile_skia.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M printing/print_destination_win.cc View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
jschuh
Minor build fix for Win64.
7 years, 11 months ago (2013-01-20 01:39:18 UTC) #1
jschuh
Seems minor enough to TBR. Please yell at me if I was wrong.
7 years, 11 months ago (2013-01-21 15:44:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jschuh@chromium.org/11953003/2001
7 years, 11 months ago (2013-01-21 15:44:25 UTC) #3
commit-bot: I haz the power
Change committed as 177940
7 years, 11 months ago (2013-01-21 17:58:29 UTC) #4
Lei Zhang
7 years, 11 months ago (2013-01-22 16:40:43 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698