Chromium Code Reviews
Help | Chromium Project | Sign in
(680)

Issue 11946058: Add password sync for Android. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 3 months ago by shashi
Modified:
1 year, 2 months ago
Reviewers:
nyquist, Nicolas Zea
CC:
chromium-reviews_chromium.org, Raghu Simha, haitaol1, akalin, timsteele
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add password sync for Android.

Android does not support password sync, enable password sync for clients
which have migrated to using Keystore. Currently, passwords will
start syncing only when sync-keystore-encryption flag is specified on the
command line.

BUG=113164
TEST=Manual

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=178443

Patch Set 1 #

Total comments: 19

Patch Set 2 : Address comments + rebase #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -7 lines) Lint Patch
M chrome/browser/sync/profile_sync_components_factory_impl.cc View 1 2 chunks +16 lines, -7 lines 0 comments ? errors Download
M chrome/browser/sync/profile_sync_service.h View 1 1 chunk +7 lines, -0 lines 0 comments ? errors Download
M chrome/browser/sync/profile_sync_service.cc View 1 2 4 chunks +33 lines, -0 lines 0 comments 1 errors Download
Commit:

Messages

Total messages: 12
shashi
1 year, 3 months ago #1
Nicolas Zea
https://chromiumcodereview.appspot.com/11946058/diff/1/chrome/browser/sync/profile_sync_components_factory_impl.cc File chrome/browser/sync/profile_sync_components_factory_impl.cc (right): https://chromiumcodereview.appspot.com/11946058/diff/1/chrome/browser/sync/profile_sync_components_factory_impl.cc#newcode142 chrome/browser/sync/profile_sync_components_factory_impl.cc:142: // On Android, enable password sync only when Keystore ...
1 year, 3 months ago #2
shashi
PTAL https://chromiumcodereview.appspot.com/11946058/diff/1/chrome/browser/sync/profile_sync_components_factory_impl.cc File chrome/browser/sync/profile_sync_components_factory_impl.cc (right): https://chromiumcodereview.appspot.com/11946058/diff/1/chrome/browser/sync/profile_sync_components_factory_impl.cc#newcode142 chrome/browser/sync/profile_sync_components_factory_impl.cc:142: // On Android, enable password sync only when ...
1 year, 3 months ago #3
Nicolas Zea
https://chromiumcodereview.appspot.com/11946058/diff/1/chrome/browser/sync/profile_sync_service.cc File chrome/browser/sync/profile_sync_service.cc (right): https://chromiumcodereview.appspot.com/11946058/diff/1/chrome/browser/sync/profile_sync_service.cc#newcode205 chrome/browser/sync/profile_sync_service.cc:205: return (passphraseType == syncer::CUSTOM_PASSPHRASE On 2013/01/18 02:06:31, shashi wrote: ...
1 year, 3 months ago #4
shashi
https://chromiumcodereview.appspot.com/11946058/diff/1/chrome/browser/sync/profile_sync_service.cc File chrome/browser/sync/profile_sync_service.cc (right): https://chromiumcodereview.appspot.com/11946058/diff/1/chrome/browser/sync/profile_sync_service.cc#newcode205 chrome/browser/sync/profile_sync_service.cc:205: return (passphraseType == syncer::CUSTOM_PASSPHRASE IsEncryptedDatatypeEnabled uses PSS.GetPreferredDataTypes() which filters ...
1 year, 3 months ago #5
Nicolas Zea
https://chromiumcodereview.appspot.com/11946058/diff/1/chrome/browser/sync/profile_sync_service.cc File chrome/browser/sync/profile_sync_service.cc (right): https://chromiumcodereview.appspot.com/11946058/diff/1/chrome/browser/sync/profile_sync_service.cc#newcode205 chrome/browser/sync/profile_sync_service.cc:205: return (passphraseType == syncer::CUSTOM_PASSPHRASE On 2013/01/18 23:20:52, shashi wrote: ...
1 year, 3 months ago #6
shashi
PTAL https://chromiumcodereview.appspot.com/11946058/diff/1/chrome/browser/sync/profile_sync_service.cc File chrome/browser/sync/profile_sync_service.cc (right): https://chromiumcodereview.appspot.com/11946058/diff/1/chrome/browser/sync/profile_sync_service.cc#newcode205 chrome/browser/sync/profile_sync_service.cc:205: return (passphraseType == syncer::CUSTOM_PASSPHRASE Yes the function name ...
1 year, 2 months ago #7
Nicolas Zea
LGTM
1 year, 2 months ago #8
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shashishekhar@chromium.org/11946058/18001
1 year, 2 months ago #9
I haz the power (commit-bot)
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
1 year, 2 months ago #10
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shashishekhar@chromium.org/11946058/18001
1 year, 2 months ago #11
I haz the power (commit-bot)
1 year, 2 months ago #12
Message was sent while issue was closed.
Change committed as 178443
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6