Chromium Code Reviews
Help | Chromium Project | Sign in
(31)

Issue 11946028: Record event activity to the extension activity log. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 3 months ago by mvrable
Modified:
1 year, 2 months ago
CC:
chromium-reviews_chromium.org, Aaron Boodman, arv, chromium-apps-reviews_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Record event activity to the extension activity log.

Log when an extension listens for an event in the extensions API, when
removing listeners, and when an event callback is triggered.

BUG=160986
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=179945

Patch Set 1 #

Patch Set 2 : Updated and rebased #

Patch Set 3 : Simplify code #

Patch Set 4 : Cleanups #

Total comments: 3

Patch Set 5 : Rebased #

Total comments: 3

Patch Set 6 : Minor bugfix #

Patch Set 7 : Update database schema if needed #

Total comments: 25

Patch Set 8 : Address reviewer feedback #

Patch Set 9 : Simplify type names in APIAction #

Patch Set 10 : Update unit tests and database schema #

Patch Set 11 : Fix for ExtensionService being unavailable during unit tests #

Total comments: 4

Patch Set 12 : Updates for reviewer comments #

Patch Set 13 : Fix ActivityLog unit test; rebase #

Patch Set 14 : Initialize ProfileManager in WebRequest unit tests #

Patch Set 15 : Second unit test update #

Patch Set 16 : Rebase #

Patch Set 17 : Rename ActivityLog::IsLoggingEnabled #

Unified diffs Side-by-side diffs Delta from patch set Stats (+345 lines, -65 lines) Lint Patch
M chrome/app/generated_resources.grd View 1 chunk +3 lines, -0 lines 0 comments ? errors Download
M chrome/browser/extensions/activity_database.h View 1 2 3 4 5 6 7 1 chunk +0 lines, -1 line 0 comments 0 errors Download
M chrome/browser/extensions/activity_database.cc View 1 2 3 4 5 6 7 2 chunks +1 line, -3 lines 0 comments 0 errors Download
M chrome/browser/extensions/activity_database_unittest.cc View 1 2 3 4 5 6 7 8 9 3 chunks +6 lines, -3 lines 0 comments 0 errors Download
M chrome/browser/extensions/activity_log.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 5 chunks +18 lines, -6 lines 0 comments ? errors Download
M chrome/browser/extensions/activity_log.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 10 chunks +81 lines, -14 lines 0 comments ? errors Download
M chrome/browser/extensions/activity_log_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 4 chunks +7 lines, -6 lines 0 comments ? errors Download
M chrome/browser/extensions/api/web_request/web_request_api.cc View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +3 lines, -2 lines 0 comments ? errors Download
M chrome/browser/extensions/api/web_request/web_request_api_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 5 chunks +7 lines, -0 lines 0 comments ? errors Download
M chrome/browser/extensions/api_actions.h View 1 2 3 4 5 6 7 8 6 chunks +25 lines, -12 lines 0 comments ? errors Download
M chrome/browser/extensions/api_actions.cc View 1 2 3 4 5 6 7 8 9 9 chunks +65 lines, -15 lines 0 comments ? errors Download
M chrome/browser/extensions/event_router.h View 1 2 3 4 5 6 7 8 9 10 11 4 chunks +12 lines, -0 lines 0 comments ? errors Download
M chrome/browser/extensions/event_router.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 6 chunks +74 lines, -2 lines 0 comments ? errors Download
M chrome/browser/resources/extensions/extension_activity.html View 1 chunk +2 lines, -0 lines 0 comments ? errors Download
M chrome/browser/ui/webui/extensions/extension_activity_ui.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +2 lines, -0 lines 0 comments ? errors Download
M chrome/test/data/extensions/activity_log/manifest.json View 1 chunk +2 lines, -1 line 0 comments ? errors Download
M chrome/test/data/extensions/activity_log/options.html View 1 chunk +1 line, -0 lines 0 comments ? errors Download
M chrome/test/data/extensions/activity_log/options.js View 2 chunks +36 lines, -0 lines 0 comments ? errors Download
Commit:

Messages

Total messages: 23
felt
Figured out why they are backwards https://codereview.chromium.org/11946028/diff/7005/chrome/browser/extensions/activity_log.cc File chrome/browser/extensions/activity_log.cc (right): https://codereview.chromium.org/11946028/diff/7005/chrome/browser/extensions/activity_log.cc#newcode176 chrome/browser/extensions/activity_log.cc:176: ActivityLog::ACTIVITY_EVENT_DISPATCH, This should ...
1 year, 3 months ago #1
felt
https://codereview.chromium.org/11946028/diff/15001/chrome/browser/extensions/api_actions.cc File chrome/browser/extensions/api_actions.cc (right): https://codereview.chromium.org/11946028/diff/15001/chrome/browser/extensions/api_actions.cc#newcode18 chrome/browser/extensions/api_actions.cc:18: "api_category LONGVARCHAR NOT NULL, " I think that the ...
1 year, 3 months ago #2
mvrable
Adrienne: Thanks for taking a look over the code. If you have more comments or ...
1 year, 3 months ago #3
felt
lgtm
1 year, 3 months ago #4
Eric Dingle
https://codereview.chromium.org/11946028/diff/20001/chrome/browser/extensions/activity_log.cc File chrome/browser/extensions/activity_log.cc (right): https://codereview.chromium.org/11946028/diff/20001/chrome/browser/extensions/activity_log.cc#newcode216 chrome/browser/extensions/activity_log.cc:216: LOG(ERROR) << "Unknown API call! " << name; Is ...
1 year, 3 months ago #5
mvrable
Thanks for the feedback; I've uploaded some changes to the code. This is a first ...
1 year, 3 months ago #6
felt
renaming sounds fine, it'll make the different actions more consistently named. On 2013/01/24 18:12:31, mvrable ...
1 year, 3 months ago #7
Eric Dingle
https://codereview.chromium.org/11946028/diff/20001/chrome/browser/extensions/activity_log.h File chrome/browser/extensions/activity_log.h (right): https://codereview.chromium.org/11946028/diff/20001/chrome/browser/extensions/activity_log.h#newcode79 chrome/browser/extensions/activity_log.h:79: const ListValue* args, // arguments to the callback Fine ...
1 year, 3 months ago #8
Eric Dingle
lgtm
1 year, 3 months ago #9
mvrable
One more update, this one renames the types in APIAction to shorten the names, and ...
1 year, 3 months ago #10
Eric Dingle
lgtm
1 year, 3 months ago #11
mvrable
Matt, Would you be able to review a patch for me? This is an extension ...
1 year, 3 months ago #12
Matt Perry
https://codereview.chromium.org/11946028/diff/24010/chrome/browser/extensions/api/web_request/web_request_api.cc File chrome/browser/extensions/api/web_request/web_request_api.cc (right): https://codereview.chromium.org/11946028/diff/24010/chrome/browser/extensions/api/web_request/web_request_api.cc#newcode1081 chrome/browser/extensions/api/web_request/web_request_api.cc:1081: (*it)->ipc_sender.get(), static_cast<Profile*>(profile), There's a reason that |profile| is a ...
1 year, 2 months ago #13
mvrable
Thanks for the suggestions for code improvements. I've uploaded a new version of the patch--can ...
1 year, 2 months ago #14
Matt Perry
lgtm
1 year, 2 months ago #15
mvrable-google
FYI: I'm current trying to track down a bug (segfault in the unit tests calling ...
1 year, 2 months ago #16
mvrable
mpcomplete: I made a couple of updates to the WebRequest unit tests, to ensure that ...
1 year, 2 months ago #17
mvrable
One more update to the patch set to fix trybot failures. It turns out that ...
1 year, 2 months ago #18
Matt Perry
lgtm
1 year, 2 months ago #19
mvrable
I just discovered that estade looks to be OOO this week. csilv: Would you be ...
1 year, 2 months ago #20
csilv
webui lgtm
1 year, 2 months ago #21
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mvrable@chromium.org/11946028/31009
1 year, 2 months ago #22
I haz the power (commit-bot)
1 year, 2 months ago #23
Message was sent while issue was closed.
Change committed as 179945
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6