Cleanup: Deprecate FileUtilProxy::RelayFileTask

Cleanup: Deprecate FileUtilProxy::RelayFileTask

Now that we have common base::PostTaskAndReplyWithResult helper method
it doesn't seem necessary anymore.

BUG=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177198

[kinuko, 2013-01-16 15:13:03]

This should be a pretty innocent change... can you take a look?

[willchan no longer on Chromium, 2013-01-16 15:53:23]

lgtm

[commit-bot: I haz the power, 2013-01-16 17:26:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kinuko@chromium.org/11946014/1

[awong, 2013-01-16 18:02:37]

lgtm w/ comment nit

https://codereview.chromium.org/11946014/diff/1/base/file_util_proxy.h
File base/file_util_proxy.h (right):

https://codereview.chromium.org/11946014/diff/1/base/file_util_proxy.h#newcode99
base/file_util_proxy.h:99: static bool Delete(TaskRunner* task_runner,
What does a "false" return mean here? Looking at the impl, it seems like the
return values for these APIs just indicate successful task posting and not
actual successful completion.  Wasn't obvious to me from the documentation
though.

[commit-bot: I haz the power, 2013-01-16 19:54:38]

Change committed as 177198

[kinuko, 2013-01-17 03:51:39]

On 2013/01/16 18:02:37, awong wrote:
> lgtm w/ comment nit
> 
> https://codereview.chromium.org/11946014/diff/1/base/file_util_proxy.h
> File base/file_util_proxy.h (right):
> 
>
https://codereview.chromium.org/11946014/diff/1/base/file_util_proxy.h#newcode99
> base/file_util_proxy.h:99: static bool Delete(TaskRunner* task_runner,
> What does a "false" return mean here? Looking at the impl, it seems like the
> return values for these APIs just indicate successful task posting and not
> actual successful completion.  Wasn't obvious to me from the documentation
> though.

Right-- I could at least update the document in the header. Shall I?

[awong, 2013-01-17 08:25:24]

Yes, I think a note about it would be good.


On Wed, Jan 16, 2013 at 7:51 PM, <kinuko@chromium.org> wrote:

> On 2013/01/16 18:02:37, awong wrote:
>
>> lgtm w/ comment nit
>>
>
>  https://codereview.chromium.**org/11946014/diff/1/base/file_**
>>
util_proxy.h<https://codereview.chromium.org/11946014/diff/1/base/file_util_proxy.h>
>> File base/file_util_proxy.h (right):
>>
>
>
> https://codereview.chromium.**org/11946014/diff/1/base/file_**
>
util_proxy.h#newcode99<https://codereview.chromium.org/11946014/diff/1/base/file_util_proxy.h#newcode99>
>
>> base/file_util_proxy.h:99: static bool Delete(TaskRunner* task_runner,
>> What does a "false" return mean here? Looking at the impl, it seems like
>> the
>> return values for these APIs just indicate successful task posting and not
>> actual successful completion.  Wasn't obvious to me from the documentation
>> though.
>>
>
> Right-- I could at least update the document in the header. Shall I?
>
>
>
https://codereview.chromium.**org/11946014/<https://codereview.chromium.org/1...
>