Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11946008: cc: Fix tree activation when invisible layers exist. (Closed)

Created:
7 years, 11 months ago by reveman
Modified:
7 years, 11 months ago
Reviewers:
nduca, enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

cc: Fix tree activation when invisible layers exist. bool() operator for PictureLayerTiling::Iterator should return false for iterator instances with empty dest_rect_. BUG=169980 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177132

Patch Set 1 #

Patch Set 2 : Add unit test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M cc/picture_layer_tiling.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M cc/picture_layer_tiling_unittest.cc View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
reveman
7 years, 11 months ago (2013-01-16 01:35:54 UTC) #1
enne (OOO)
Ack, great catch. Can you put a quick test in picture_layer_tiling_unittest.cc?
7 years, 11 months ago (2013-01-16 01:39:37 UTC) #2
reveman
On 2013/01/16 01:39:37, enne wrote: > Ack, great catch. > > Can you put a ...
7 years, 11 months ago (2013-01-16 02:28:01 UTC) #3
enne (OOO)
lgtm
7 years, 11 months ago (2013-01-16 02:29:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reveman@chromium.org/11946008/4001
7 years, 11 months ago (2013-01-16 02:31:47 UTC) #5
commit-bot: I haz the power
Retried try job too often on win for step(s) compile
7 years, 11 months ago (2013-01-16 04:26:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reveman@chromium.org/11946008/4001
7 years, 11 months ago (2013-01-16 10:28:04 UTC) #7
commit-bot: I haz the power
7 years, 11 months ago (2013-01-16 11:40:23 UTC) #8
Message was sent while issue was closed. 
Change committed as 177132

Powered by Google App Engine
This is Rietveld 408576698