[NaCl SDK] Fix update issues in sdk_tools.

[NaCl SDK] Fix update issues in sdk_tools.

* "naclsdk update" (i.e. update recommended) was broken
* "naclsdk update pepper_canary" would make a directory called "pepper_26" not
  "pepper_canary".

BUG=none
R=sbc@chromium.org,noelallen@chromium.org
NOTRY=true


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177187

[Sam Clegg, 2013-01-15 22:56:02]

https://codereview.chromium.org/11946002/diff/1/native_client_sdk/src/build_t...
File native_client_sdk/src/build_tools/sdk_tools/command/update.py (right):

https://codereview.chromium.org/11946002/diff/1/native_client_sdk/src/build_t...
native_client_sdk/src/build_tools/sdk_tools/command/update.py:222: rename_to_dir
= bundle.name
I'm not sure what 'repath' is supposed to do.  I guess its how to you tell
pepper_canary to install as pepper_canary rather than pepper_2X?

It looks like 'rename_to_dir' is always set to the same value there so doesn't
need to be inside the conditional.

https://codereview.chromium.org/11946002/diff/1/native_client_sdk/src/build_t...
File native_client_sdk/src/build_tools/tests/sdktools_commands_test.py (right):

https://codereview.chromium.org/11946002/diff/1/native_client_sdk/src/build_t...
native_client_sdk/src/build_tools/tests/sdktools_commands_test.py:227: without
args."""
nit: I think multiline docstrings are supposed to have the final """ in a line
by itself:

http://www.python.org/dev/peps/pep-0257/#multi-line-docstrings

https://codereview.chromium.org/11946002/diff/1/native_client_sdk/src/build_t...
native_client_sdk/src/build_tools/tests/sdktools_commands_test.py:236: """The
update command should create the correct directory name for repath'd
ditto

https://codereview.chromium.org/11946002/diff/1/native_client_sdk/src/build_t...
native_client_sdk/src/build_tools/tests/sdktools_commands_test.py:247:
sys.exit(unittest.main())
I know you are not changing this but I just noticed the redundant sys.exit()
here.  unittest.main() calls sys.exit() and doesn't return.

Maybe I should just open a bug to check that we always follow the pattern here..

[binji, 2013-01-15 22:59:39]

https://codereview.chromium.org/11946002/diff/1/native_client_sdk/src/build_t...
File native_client_sdk/src/build_tools/sdk_tools/command/update.py (right):

https://codereview.chromium.org/11946002/diff/1/native_client_sdk/src/build_t...
native_client_sdk/src/build_tools/sdk_tools/command/update.py:222: rename_to_dir
= bundle.name
On 2013/01/15 22:56:02, Sam Clegg wrote:
> I'm not sure what 'repath' is supposed to do.  I guess its how to you tell
> pepper_canary to install as pepper_canary rather than pepper_2X?
> 
> It looks like 'rename_to_dir' is always set to the same value there so doesn't
> need to be inside the conditional. 

Done.

https://codereview.chromium.org/11946002/diff/1/native_client_sdk/src/build_t...
File native_client_sdk/src/build_tools/tests/sdktools_commands_test.py (right):

https://codereview.chromium.org/11946002/diff/1/native_client_sdk/src/build_t...
native_client_sdk/src/build_tools/tests/sdktools_commands_test.py:227: without
args."""
On 2013/01/15 22:56:02, Sam Clegg wrote:
> nit: I think multiline docstrings are supposed to have the final """ in a line
> by itself:
> 
> http://www.python.org/dev/peps/pep-0257/#multi-line-docstrings

Done.

https://codereview.chromium.org/11946002/diff/1/native_client_sdk/src/build_t...
native_client_sdk/src/build_tools/tests/sdktools_commands_test.py:236: """The
update command should create the correct directory name for repath'd
On 2013/01/15 22:56:02, Sam Clegg wrote:
> ditto

Done.

https://codereview.chromium.org/11946002/diff/1/native_client_sdk/src/build_t...
native_client_sdk/src/build_tools/tests/sdktools_commands_test.py:247:
sys.exit(unittest.main())
On 2013/01/15 22:56:02, Sam Clegg wrote:
> I know you are not changing this but I just noticed the redundant sys.exit()
> here.  unittest.main() calls sys.exit() and doesn't return.
> 
> Maybe I should just open a bug to check that we always follow the pattern
here..

Done.

[Sam Clegg, 2013-01-15 23:00:54]

lgtm (won't help you submit I'm afraid :)

[noelallen1, 2013-01-16 01:00:27]

lgtm

[commit-bot: I haz the power, 2013-01-16 18:51:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/binji@chromium.org/11946002/5001

[commit-bot: I haz the power, 2013-01-16 19:00:04]

Change committed as 177187