Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 11944002: Make names consistent in GpuMemoryManager (Closed)

Created:
7 years, 11 months ago by ccameron
Modified:
7 years, 11 months ago
Reviewers:
greggman
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium
Visibility:
Public.

Description

Make names consistent in GpuMemoryManager. Prefer nonvisible to backgrounded, client to tab, nicetohave to nice_to_have, and allocation to budget. BUG=168413 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177244

Patch Set 1 #

Patch Set 2 : Fix unit test build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+166 lines, -165 lines) Patch
M content/common/gpu/gpu_memory_manager.h View 1 6 chunks +10 lines, -10 lines 0 comments Download
M content/common/gpu/gpu_memory_manager.cc View 23 chunks +81 lines, -81 lines 0 comments Download
M content/common/gpu/gpu_memory_manager_client.h View 1 chunk +7 lines, -6 lines 0 comments Download
M content/common/gpu/gpu_memory_manager_client.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M content/common/gpu/gpu_memory_manager_unittest.cc View 1 18 chunks +64 lines, -64 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
ccameron
This is just a renaming change, not substantial. I was having trouble naming variables while ...
7 years, 11 months ago (2013-01-15 22:50:01 UTC) #1
greggman
lgtm not sure about nicetohave. That seems not in line with the style guide.
7 years, 11 months ago (2013-01-16 00:32:20 UTC) #2
ccameron
Thanks! I'd like to come up with something better than nicetohave (having something with multiple ...
7 years, 11 months ago (2013-01-16 00:33:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ccameron@chromium.org/11944002/1
7 years, 11 months ago (2013-01-16 00:35:56 UTC) #4
greggman
On 2013/01/16 00:33:53, ccameron1 wrote: > Thanks! > > I'd like to come up with ...
7 years, 11 months ago (2013-01-16 00:36:44 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) aura_unittests, compositor_unittests, content_browsertests, content_unittests, interactive_ui_tests, unit_tests, ...
7 years, 11 months ago (2013-01-16 01:25:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ccameron@chromium.org/11944002/5002
7 years, 11 months ago (2013-01-16 02:02:37 UTC) #7
commit-bot: I haz the power
Retried try job too often on win for step(s) compile
7 years, 11 months ago (2013-01-16 04:06:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ccameron@chromium.org/11944002/5002
7 years, 11 months ago (2013-01-16 19:56:58 UTC) #9
commit-bot: I haz the power
7 years, 11 months ago (2013-01-16 22:53:02 UTC) #10
Message was sent while issue was closed.
Change committed as 177244

Powered by Google App Engine
This is Rietveld 408576698