Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 11941022: Refactor FileIO to the new resource host system. (Closed)

Created:
7 years, 11 months ago by bbudge
Modified:
7 years, 11 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, jam, darin-cc_chromium.org
Visibility:
Public.

Description

Refactor FileIO to the new resource host system. Taking over from Victor's CL: https://codereview.chromium.org/11419131/ Re-landing, with a fix. The original waited to reset the file state until after the callback had completed. This is too late, as the client should be able to perform another file operation during the callback. Changeset #1 is the original patch. The fix is in change set #2 Original author=Victor Hsieh BUG=none TEST=browser_tests --gtest_filter=PPAPINaClNewlibTest.FileIO* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177830

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1263 lines, -1571 lines) Patch
M content/content_renderer.gypi View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/pepper/content_renderer_pepper_host_factory.cc View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
A content/renderer/pepper/pepper_file_io_host.h View 1 chunk +129 lines, -0 lines 0 comments Download
A content/renderer/pepper/pepper_file_io_host.cc View 1 chunk +566 lines, -0 lines 0 comments Download
M content/renderer/pepper/pepper_in_process_resource_creation.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/pepper/pepper_in_process_resource_creation.cc View 1 2 2 chunks +8 lines, -0 lines 0 comments Download
M content/renderer/pepper/pepper_plugin_delegate_impl.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/ppapi_proxy.gypi View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/ppapi_shared.gypi View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
A ppapi/proxy/file_io_resource.h View 1 chunk +95 lines, -0 lines 0 comments Download
A ppapi/proxy/file_io_resource.cc View 1 2 1 chunk +291 lines, -0 lines 0 comments Download
M ppapi/proxy/interface_list.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/proxy/ppapi_messages.h View 1 2 3 chunks +32 lines, -53 lines 0 comments Download
D ppapi/proxy/ppb_file_io_proxy.h View 1 2 1 chunk +0 lines, -93 lines 0 comments Download
D ppapi/proxy/ppb_file_io_proxy.cc View 1 2 1 chunk +0 lines, -457 lines 0 comments Download
M ppapi/proxy/resource_creation_proxy.cc View 1 2 3 chunks +2 lines, -2 lines 0 comments Download
A ppapi/shared_impl/file_io_state_manager.h View 1 chunk +69 lines, -0 lines 0 comments Download
A ppapi/shared_impl/file_io_state_manager.cc View 1 chunk +56 lines, -0 lines 0 comments Download
D ppapi/shared_impl/ppb_file_io_shared.h View 1 2 1 chunk +0 lines, -159 lines 0 comments Download
D ppapi/shared_impl/ppb_file_io_shared.cc View 1 2 1 chunk +0 lines, -244 lines 0 comments Download
M ppapi/thunk/interfaces_ppb_private.h View 1 2 2 chunks +2 lines, -3 lines 0 comments Download
M ppapi/thunk/interfaces_ppb_public_stable.h View 1 2 3 chunks +2 lines, -3 lines 0 comments Download
M webkit/glue/webkit_glue.gypi View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
D webkit/plugins/ppapi/ppb_file_io_impl.h View 1 2 1 chunk +0 lines, -110 lines 0 comments Download
D webkit/plugins/ppapi/ppb_file_io_impl.cc View 1 2 1 chunk +0 lines, -433 lines 0 comments Download
M webkit/plugins/ppapi/resource_creation_impl.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M webkit/plugins/ppapi/resource_creation_impl.cc View 1 2 2 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
bbudge
Re-landing Victor's CL. The fix is in Changeset #2.
7 years, 11 months ago (2013-01-18 21:25:41 UTC) #1
brettw
lgtm
7 years, 11 months ago (2013-01-18 21:34:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bbudge@chromium.org/11941022/14005
7 years, 11 months ago (2013-01-18 22:06:58 UTC) #3
commit-bot: I haz the power
Presubmit check for 11941022-14005 failed and returned exit status 1. Running presubmit commit checks ...
7 years, 11 months ago (2013-01-18 22:07:07 UTC) #4
bbudge
Julien for IPC review of ppapi_messages.h. You've already reviewed it and even rubber stamped it ...
7 years, 11 months ago (2013-01-18 22:10:04 UTC) #5
jln (very slow on Chromium)
On 2013/01/18 22:10:04, bbudge1 wrote: > Julien for IPC review of ppapi_messages.h. You've already reviewed ...
7 years, 11 months ago (2013-01-18 22:29:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bbudge@chromium.org/11941022/14005
7 years, 11 months ago (2013-01-18 22:30:11 UTC) #7
commit-bot: I haz the power
7 years, 11 months ago (2013-01-19 04:16:43 UTC) #8
Message was sent while issue was closed.
Change committed as 177830

Powered by Google App Engine
This is Rietveld 408576698