Migrate FunctionPrototype (Keyed|Named)LoadIC to CodeStub

src/ic.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 818 matching lines @@
   if (result->IsJSFunction()) return *result;
 
   return TypeError("property_not_function", object, key);
 }
 
 
 bool IC::HandleLoad(State state,
                     Handle<Object> object,
                     Handle<String> name,
                     MaybeObject** result) {
-  // Use specialized code for getting the length of strings and
-  // string wrapper objects.  The length property of string wrapper
-  // objects is read-only and therefore always returns the length of
-  // the underlying string value.  See ECMA-262 15.5.5.1.
-  if ((object->IsString() || object->IsStringWrapper()) &&
-      name->Equals(isolate()->heap()->length_symbol())) {
-    Handle<Code> stub;
-    if (state == UNINITIALIZED) {
-      stub = pre_monomorphic_stub();
-    } else if (state == PREMONOMORPHIC) {
-      StringLengthStub string_length_stub(kind(), !object->IsString());
-      stub = string_length_stub.GetCode();
-    } else if (state == MONOMORPHIC && object->IsStringWrapper()) {
-      StringLengthStub string_length_stub(kind(), true);
-      stub = string_length_stub.GetCode();
-    } else if (state != MEGAMORPHIC) {
-      ASSERT(state != GENERIC);
-      stub = megamorphic_stub();
+  if (FLAG_use_ic) {
+    // Use specialized code for getting the length of strings and
+    // string wrapper objects.  The length property of string wrapper
+    // objects is read-only and therefore always returns the length of
+    // the underlying string value.  See ECMA-262 15.5.5.1.
+    if ((object->IsString() || object->IsStringWrapper()) &&
+        name->Equals(isolate()->heap()->length_symbol())) {
+      Handle<Code> stub;
+      if (state == UNINITIALIZED) {
+        stub = pre_monomorphic_stub();
+      } else if (state == PREMONOMORPHIC) {
+        StringLengthStub string_length_stub(kind(), !object->IsString());
+        stub = string_length_stub.GetCode();
+      } else if (state == MONOMORPHIC && object->IsStringWrapper()) {
+        StringLengthStub string_length_stub(kind(), true);
+        stub = string_length_stub.GetCode();
+      } else if (state != MEGAMORPHIC) {
+        ASSERT(state != GENERIC);
+        stub = megamorphic_stub();
+      }
+      if (!stub.is_null()) {
+        set_target(*stub);
+#ifdef DEBUG
+        if (FLAG_trace_ic) PrintF("[LoadIC : +#length /string]\n");
+#endif
+      }
+      // Get the string if we have a string wrapper object.
+      Handle<Object> string = object->IsJSValue()
+          ? Handle<Object>(Handle<JSValue>::cast(object)->value())
+          : object;
+      *result = Smi::FromInt(String::cast(*string)->length());
+      return true;
     }
-    if (!stub.is_null()) {
-      set_target(*stub);
+
+    // Use specialized code for getting the length of arrays.
+    if (object->IsJSArray() &&
+        name->Equals(isolate()->heap()->length_symbol())) {
+      Handle<Code> stub;
+      if (state == UNINITIALIZED) {
+        stub = pre_monomorphic_stub();
+      } else if (state == PREMONOMORPHIC) {
+        ArrayLengthStub array_length_stub(kind());
+        stub = array_length_stub.GetCode();
+      } else if (state != MEGAMORPHIC) {
+        ASSERT(state != GENERIC);
+        stub = megamorphic_stub();
+      }
+      if (!stub.is_null()) {
+        set_target(*stub);
 #ifdef DEBUG
-      if (FLAG_trace_ic) PrintF("[LoadIC : +#length /string]\n");
+        if (FLAG_trace_ic) PrintF("[LoadIC : +#length /array]\n");
 #endif
-    }
-    // Get the string if we have a string wrapper object.
-    Handle<Object> string = object->IsJSValue()
-        ? Handle<Object>(Handle<JSValue>::cast(object)->value())
-        : object;
-    *result = Smi::FromInt(String::cast(*string)->length());
-    return true;
-  }
-
-  // Use specialized code for getting the length of arrays.
-  if (object->IsJSArray() && name->Equals(isolate()->heap()->length_symbol())) {
-    Handle<Code> stub;
-    if (state == UNINITIALIZED) {
-      stub = pre_monomorphic_stub();
-    } else if (state == PREMONOMORPHIC) {
-      ArrayLengthStub array_length_stub(kind());
-      stub = array_length_stub.GetCode();
-    } else if (state != MEGAMORPHIC) {
-      ASSERT(state != GENERIC);
-      stub = megamorphic_stub();
-    }
-    if (!stub.is_null()) {
-      set_target(*stub);
-#ifdef DEBUG
-      if (FLAG_trace_ic) PrintF("[LoadIC : +#length /array]\n");
-#endif
-    }
-    *result = JSArray::cast(*object)->length();
-    return true;
-  }
-
-  return false;
-}
-
-
-MaybeObject* LoadIC::Load(State state,
-                          Handle<Object> object,
-                          Handle<String> name) {
-  // If the object is undefined or null it's illegal to try to get any
-  // of its properties; throw a TypeError in that case.
-  if (object->IsUndefined() || object->IsNull()) {
-    return TypeError("non_object_property_load", object, name);
-  }
-
-  if (FLAG_use_ic) {
-    MaybeObject* result;
-    if (HandleLoad(state, object, name, &result)) {
-      return result;
+      }
+      *result = JSArray::cast(*object)->length();
+      return true;
     }
 
     // Use specialized code for getting prototype of functions.
     if (object->IsJSFunction() &&
         name->Equals(isolate()->heap()->prototype_symbol()) &&
         Handle<JSFunction>::cast(object)->should_have_prototype()) {
       Handle<Code> stub;
       if (state == UNINITIALIZED) {
         stub = pre_monomorphic_stub();
       } else if (state == PREMONOMORPHIC) {
-        stub = isolate()->builtins()->LoadIC_FunctionPrototype();
+        FunctionPrototypeStub function_prototype_stub(kind());
+        stub = function_prototype_stub.GetCode();
       } else if (state != MEGAMORPHIC) {
         ASSERT(state != GENERIC);
         stub = megamorphic_stub();
       }
       if (!stub.is_null()) {
         set_target(*stub);
 #ifdef DEBUG
         if (FLAG_trace_ic) PrintF("[LoadIC : +#prototype /function]\n");
 #endif
       }
-      return Accessors::FunctionGetPrototype(*object, 0);
+      *result = Accessors::FunctionGetPrototype(*object, 0);
+      return true;
     }
   }
 
+  return false;
+}
+
+
+MaybeObject* LoadIC::Load(State state,
+                          Handle<Object> object,
+                          Handle<String> name) {
+  // If the object is undefined or null it's illegal to try to get any
+  // of its properties; throw a TypeError in that case.
+  if (object->IsUndefined() || object->IsNull()) {
+    return TypeError("non_object_property_load", object, name);
+  }
+
+  MaybeObject* result;
+  if (HandleLoad(state, object, name, &result)) {
+    return result;
+  }
+
   // Check if the name is trivially convertible to an index and get
   // the element if so.
   uint32_t index;
   if (name->AsArrayIndex(&index)) return object->GetElement(index);
 
   // Named lookup in the object.
   LookupResult lookup(isolate());
   LookupForRead(object, name, &lookup);
 
   // If we did not find a property, check if we need to throw an exception.
@@ skipping 217 matching lines @@
 
   if (key->IsSymbol()) {
     Handle<String> name = Handle<String>::cast(key);
 
     // If the object is undefined or null it's illegal to try to get any
     // of its properties; throw a TypeError in that case.
     if (object->IsUndefined() || object->IsNull()) {
       return TypeError("non_object_property_load", object, name);
     }
 
-    if (FLAG_use_ic) {
-      MaybeObject* result;
-      if (HandleLoad(state, object, name, &result)) {
-        return result;
-      }
-
-      // TODO(1073): don't ignore the current stub state.
-      // Use specialized code for getting prototype of functions.
-      if (object->IsJSFunction() &&
-          name->Equals(isolate()->heap()->prototype_symbol()) &&
-          Handle<JSFunction>::cast(object)->should_have_prototype()) {
-        Handle<JSFunction> function = Handle<JSFunction>::cast(object);
-        Handle<Code> code =
-            isolate()->stub_cache()->ComputeKeyedLoadFunctionPrototype(
-                name, function);
-        ASSERT(!code.is_null());
-        set_target(*code);
-        TRACE_IC("KeyedLoadIC", name, state, target());
-        return Accessors::FunctionGetPrototype(*object, 0);
-      }
+    MaybeObject* result;
+    if (HandleLoad(state, object, name, &result)) {
+      return result;
     }
 
     // Check if the name is trivially convertible to an index and get
     // the element or char if so.
     uint32_t index = 0;
     if (name->AsArrayIndex(&index)) {
       // Rewrite to the generic keyed load stub.
       if (FLAG_use_ic) set_target(*generic_stub());
       return Runtime::GetElementOrCharAt(isolate(), object, index);
     }
@@ skipping 1669 matching lines @@
 #undef ADDR
 };
 
 
 Address IC::AddressFromUtilityId(IC::UtilityId id) {
   return IC_utilities[id];
 }
 
 
 } }  // namespace v8::internal