Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Unified Diff: content/browser/download/download_manager_impl.h

Issue 11941015: Move OpenItem/ShowItemInFolder from ContentBrowserClient to DownloadManagerDelegate (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: _ Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/download/download_manager_impl.h
diff --git a/content/browser/download/download_manager_impl.h b/content/browser/download/download_manager_impl.h
index d5a3c9d4f459cd99cfe308fd479aa6df12b05db5..de7ad5d118ea91fff76237a9c11b46d3884f1f45 100644
--- a/content/browser/download/download_manager_impl.h
+++ b/content/browser/download/download_manager_impl.h
@@ -78,6 +78,7 @@ class CONTENT_EXPORT DownloadManagerImpl : public DownloadManager,
virtual BrowserContext* GetBrowserContext() const OVERRIDE;
virtual void CheckForHistoryFilesRemoval() OVERRIDE;
virtual DownloadItem* GetDownload(int id) OVERRIDE;
+ virtual void MockDownloadOpenForTesting() OVERRIDE;
// For testing; specifically, accessed from TestFileErrorInjector.
void SetDownloadItemFactoryForTesting(
@@ -133,7 +134,8 @@ class CONTENT_EXPORT DownloadManagerImpl : public DownloadManager,
virtual void ResumeInterruptedDownload(
scoped_ptr<content::DownloadUrlParameters> params,
content::DownloadId id) OVERRIDE;
- virtual void DownloadOpened(DownloadItemImpl* download) OVERRIDE;
+ virtual void OpenDownload(DownloadItemImpl* download) OVERRIDE;
+ virtual void ShowDownloadInShell(DownloadItemImpl* download) OVERRIDE;
virtual void DownloadRemoved(DownloadItemImpl* download) OVERRIDE;
virtual void ShowDownloadInBrowser(DownloadItemImpl* download) OVERRIDE;
@@ -165,6 +167,9 @@ class CONTENT_EXPORT DownloadManagerImpl : public DownloadManager,
net::NetLog* net_log_;
+ // Do we actually open downloads when requested? For testing purposes only.
+ bool open_enabled_;
+
DISALLOW_COPY_AND_ASSIGN(DownloadManagerImpl);
};

Powered by Google App Engine
This is Rietveld 408576698