Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 11941002: Set msvs_cygwin_shell default to 0 (Closed)

Created:
7 years, 11 months ago by iannucci
Modified:
7 years, 11 months ago
Reviewers:
scottmg
CC:
chromium-reviews
Visibility:
Public.

Description

Set msvs_cygwin_shell default to 0 This will cause all actions which do not have 'msvs_cygwin_shell': 1 to be run under cmd.exe. BUG=158680, 123026 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=178146

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M build/common.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
iannucci
A deceptively simple change... PTAL :)
7 years, 11 months ago (2013-01-19 02:06:02 UTC) #1
scottmg
if it works... :) lgtm
7 years, 11 months ago (2013-01-19 04:25:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/iannucci@chromium.org/11941002/18001
7 years, 11 months ago (2013-01-19 19:35:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/iannucci@chromium.org/11941002/33001
7 years, 11 months ago (2013-01-22 21:22:06 UTC) #4
commit-bot: I haz the power
7 years, 11 months ago (2013-01-22 23:05:52 UTC) #5
Message was sent while issue was closed.
Change committed as 178146

Powered by Google App Engine
This is Rietveld 408576698