Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(794)

Issue 11938034: drive: Replace local FakeDriveService with google_apis::FakeDriveService part 3 (Closed)

Created:
7 years, 11 months ago by satorux1
Modified:
7 years, 11 months ago
Reviewers:
kinaba
CC:
chromium-reviews, nkostylev+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

drive: Replace local FakeDriveService with google_apis::FakeDriveService part 3 external_filesystem_apitest.cc is now a lot simpler. BUG=169194 TEST=none; test changes Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=178796

Patch Set 1 : polish #

Patch Set 2 : rebase #

Patch Set 3 : start-index -> start-offset #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -241 lines) Patch
M chrome/browser/chromeos/extensions/external_filesystem_apitest.cc View 1 7 chunks +13 lines, -122 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
D chrome/test/data/chromeos/gdata/remote_file_system_apitest_document_to_download.json View 1 chunk +0 lines, -100 lines 0 comments Download
M chrome/test/data/extensions/api_test/filebrowser_component/remote.js View 1 chunk +7 lines, -5 lines 0 comments Download
M chrome/test/data/extensions/api_test/filebrowser_component/remote_search.js View 1 2 5 chunks +39 lines, -14 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
satorux1
The last local FakeDriveService to be gone. This depends on https://codereview.chromium.org/12017026/
7 years, 11 months ago (2013-01-18 23:04:54 UTC) #1
kinaba
lgtm
7 years, 11 months ago (2013-01-19 03:54:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/satorux@chromium.org/11938034/18001
7 years, 11 months ago (2013-01-25 07:41:05 UTC) #3
commit-bot: I haz the power
7 years, 11 months ago (2013-01-25 09:25:07 UTC) #4
Message was sent while issue was closed.
Change committed as 178796

Powered by Google App Engine
This is Rietveld 408576698