ChromeOS default switches cleanup - switches::kEnableThreadedCompositing and switches::kEnableSmoot…

ChromeOS default switches cleanup - switches::kEnableThreadedCompositing and switches::kEnableSmoothScrolling should not be an option on ChromeOS anymore.

BUG=170948
TEST=existing tests


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177859

[piman, 2013-01-18 23:25:20]

Ok, so you had me look at all the uses of the flags.

For kEnableThreadedCompositing, on Chrome OS, nothing in the browser directly
uses it. It gets tested explicitly in the renderer, but it gets added on the
command-line for the renderer based on the value of
IsThreadedCompositingEnabled. It's irrelevant for other processes. So for that
one we're good.

For kForceCompositingMode however, it's used directly in
WebContentsImpl::GetWebkitPrefs (i.e. not based on
IsForceCompositingModeEnabled), which is in the browser process. So that needs
fixing. The renderer doesn't directly read that flag, and it's irrelevant on
other processes.

kEnableSmoothScrolling looks fine with your change.

[zel, 2013-01-19 02:02:55]

On 2013/01/18 23:25:20, piman wrote:
> Ok, so you had me look at all the uses of the flags.
> 
> For kEnableThreadedCompositing, on Chrome OS, nothing in the browser directly
> uses it. It gets tested explicitly in the renderer, but it gets added on the
> command-line for the renderer based on the value of
> IsThreadedCompositingEnabled. It's irrelevant for other processes. So for that
> one we're good.
> 
> For kForceCompositingMode however, it's used directly in
> WebContentsImpl::GetWebkitPrefs (i.e. not based on
> IsForceCompositingModeEnabled), which is in the browser process. So that needs
> fixing. The renderer doesn't directly read that flag, and it's irrelevant on
> other processes.
> 
> kEnableSmoothScrolling looks fine with your change.

PTAL, I took care for WebContentsImpl::GetWebkitPrefs() part.

[piman, 2013-01-19 02:04:31]

lgtm

[commit-bot: I haz the power, 2013-01-19 03:26:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/zelidrag@chromium.org/11938025/9004

[commit-bot: I haz the power, 2013-01-20 01:09:27]

Change committed as 177859