Issue 11938013: Migrate ArrayLength (Keyed|Named)LoadIC to CodeStub

Issue 11938013: Migrate ArrayLength (Keyed|Named)LoadIC to CodeStub (Closed)

Created:
7 years, 11 months ago by Toon Verwaest

Modified:
7 years, 11 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Migrate ArrayLength (Keyed|Named)LoadIC to CodeStub Committed: https://code.google.com/p/v8/source/detail?r=13458

Patch Set 1 #

Total comments: 6

Patch Set 2 : Addressed comments #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+115 lines, -179 lines)			Patch
M	src/arm/code-stubs-arm.cc	View	1	1 chunk	+29 lines, -0 lines	0 comments	Download
M	src/arm/ic-arm.cc	View		1 chunk	+0 lines, -15 lines	0 comments	Download
M	src/arm/stub-cache-arm.cc	View		1 chunk	+0 lines, -21 lines	0 comments	Download
M	src/ast.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	src/builtins.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/builtins.cc	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	src/code-stubs.h	View	1	2 chunks	+15 lines, -0 lines	0 comments	Download
M	src/ia32/code-stubs-ia32.cc	View	1	1 chunk	+19 lines, -0 lines	0 comments	Download
M	src/ia32/ic-ia32.cc	View		1 chunk	+0 lines, -14 lines	0 comments	Download
M	src/ia32/stub-cache-ia32.cc	View		1 chunk	+0 lines, -26 lines	0 comments	Download
M	src/ic.cc	View		3 chunks	+23 lines, -33 lines	0 comments	Download
M	src/stub-cache.h	View		2 chunks	+0 lines, -5 lines	0 comments	Download
M	src/stub-cache.cc	View		1 chunk	+0 lines, -17 lines	0 comments	Download
M	src/x64/code-stubs-x64.cc	View	1	1 chunk	+27 lines, -0 lines	0 comments	Download
M	src/x64/ic-x64.cc	View		1 chunk	+0 lines, -14 lines	0 comments	Download
M	src/x64/stub-cache-x64.cc	View		1 chunk	+0 lines, -26 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Toon Verwaest

PTAL. Depends on https://chromiumcodereview.appspot.com/11973008/.

7 years, 11 months ago (2013-01-18 10:19:48 UTC) #1

Jakob Kummerow

LGTM with nits. Mechanical changes indeed -- I could almost write a small script that ...

7 years, 11 months ago (2013-01-21 16:35:14 UTC) #2

Toon Verwaest

7 years, 11 months ago (2013-01-21 17:16:17 UTC) #3

Addressed comments

https://chromiumcodereview.appspot.com/11938013/diff/1/src/builtins.cc
File src/builtins.cc (right):

https://chromiumcodereview.appspot.com/11938013/diff/1/src/builtins.cc#newcod...
src/builtins.cc:1456: static void
Generate_LoadIC_FunctionPrototype(MacroAssembler* masm) {
Yes.

On 2013/01/21 16:35:15, Jakob wrote:
> This is a Rietveld bug, right?

https://chromiumcodereview.appspot.com/11938013/diff/1/src/code-stubs.h
File src/code-stubs.h (right):

https://chromiumcodereview.appspot.com/11938013/diff/1/src/code-stubs.h#newco...
src/code-stubs.h:564: Code::Kind kind_;
On 2013/01/21 16:35:15, Jakob wrote:
> again, make the field private and define a protected getter, please.

Done.

https://chromiumcodereview.appspot.com/11938013/diff/1/src/x64/code-stubs-x64.cc
File src/x64/code-stubs-x64.cc (right):

https://chromiumcodereview.appspot.com/11938013/diff/1/src/x64/code-stubs-x64...
src/x64/code-stubs-x64.cc:2374: } else {
On 2013/01/21 16:35:15, Jakob wrote:
> again, an ASSERT(kind() == Code::LOAD_IC) please.

Done.

Expand Messages | Collapse Messages