Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 11938002: Android: fix cpu governor setup for perf tests (Closed)

Created:
7 years, 11 months ago by aberent
Modified:
7 years, 11 months ago
Reviewers:
bulach
CC:
chromium-reviews, ilevy+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, peter+watch_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Android: fix cpu governor setup for perf tests The test code was incorrectly counting the number of CPUs, and hence was only setting performance mode on, at most, n-1 of them. This meant that the results of the perf tests (at least the startup tests) depended on how Chrome distributed itself between CPUs. BUG=163336 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177143

Patch Set 1 : Fix random changes in perf test results #

Total comments: 1

Patch Set 2 : Fix random changes in perf test results - code review revision #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -8 lines) Patch
M build/android/pylib/perf_tests_helper.py View 1 3 chunks +11 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
aberent
I will need to make further changes to this to make this work on user ...
7 years, 11 months ago (2013-01-15 21:46:48 UTC) #1
bulach
lgtm, great find! suggest changing the title to something like: Android: fix cpu governor setup ...
7 years, 11 months ago (2013-01-16 09:34:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aberent@chromium.org/11938002/5001
7 years, 11 months ago (2013-01-16 10:55:56 UTC) #3
commit-bot: I haz the power
7 years, 11 months ago (2013-01-16 13:21:37 UTC) #4
Message was sent while issue was closed.
Change committed as 177143

Powered by Google App Engine
This is Rietveld 408576698