Put latest_rev data in datastore instead of memcache.

Put latest_rev data in datastore instead of memcache.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=176984

[agable, 2013-01-15 21:42:04]

Ryan for review, Chase for owner.

Increases stability across multiple instances spinning up and down and receiving
requests before their memcache is repopulated. Prevents latest_rev not found in
memcache-related 500s.

[Ryan Tseng, 2013-01-15 22:05:32]

https://chromiumcodereview.appspot.com/11934003/diff/1/app.py
File app.py (right):

https://chromiumcodereview.appspot.com/11934003/diff/1/app.py#newcode215
app.py:215: if row_data and type(row_data) == type({}):
In what cases would it not be a dict?

https://chromiumcodereview.appspot.com/11934003/diff/1/app.py#newcode217
app.py:217: row = Row.all().filter('localpath =', localpath).get()
How many entires can we expect this to return?

[cmp, 2013-01-15 22:07:28]

lgtm with hinoka's review

[agable, 2013-01-15 22:09:41]

https://chromiumcodereview.appspot.com/11934003/diff/1/app.py
File app.py (right):

https://chromiumcodereview.appspot.com/11934003/diff/1/app.py#newcode215
app.py:215: if row_data and type(row_data) == type({}):
On 2013/01/15 22:05:32, Ryan T. wrote:
> In what cases would it not be a dict?

The latest_rev row used to be stored in memcache as a plain int. I want to make
sure it never picks up that int and tries to use it instead.

https://chromiumcodereview.appspot.com/11934003/diff/1/app.py#newcode217
app.py:217: row = Row.all().filter('localpath =', localpath).get()
On 2013/01/15 22:05:32, Ryan T. wrote:
> How many entires can we expect this to return?

Exactly one. It is being replaced by row = Row.get_by_key_name(localpath) in a
different CL.

[Ryan Tseng, 2013-01-15 22:15:03]

lgtm

[commit-bot: I haz the power, 2013-01-15 22:16:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/agable@chromium.org/11934003/7001

[commit-bot: I haz the power, 2013-01-15 22:16:36]

Change committed as 176984