Support Visual Studio Express 2012.

Support Visual Studio Express 2012.

Remove Visual Studio 2005 and 2008 support from
build/common.gypi.

R=mark@chromium.org,scottmg@chromium.org
BUG=171142
TEST=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=178369

[wtc, 2013-01-20 01:14:38]

https://codereview.chromium.org/11933005/diff/1/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/11933005/diff/1/build/common.gypi#newcode1285
build/common.gypi:1285: ['MSVS_VERSION=="2012e" or MSVS_VERSION=="2010e" or
MSVS_VERSION=="2008e" or MSVS_VERSION=="2005e"', {

Do you want me to remove MSVS_VERSION=="2005e"?

What about MSVS_VERSION=="2008e"?

https://codereview.chromium.org/11933005/diff/1/testing/gtest.gyp
File testing/gtest.gyp (right):

https://codereview.chromium.org/11933005/diff/1/testing/gtest.gyp#newcode143
testing/gtest.gyp:143: ['OS=="win" and MSVS_VERSION=="2012e"', {

I need help with this. Would this work?

  'OS=="win" and (MSVS_VERSION=="2012" or MSVS_VERSION=="2012e")'

[scottmg, 2013-01-22 18:13:17]

https://codereview.chromium.org/11933005/diff/1/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/11933005/diff/1/build/common.gypi#newcode1285
build/common.gypi:1285: ['MSVS_VERSION=="2012e" or MSVS_VERSION=="2010e" or
MSVS_VERSION=="2008e" or MSVS_VERSION=="2005e"', {
On 2013/01/20 01:14:38, wtc wrote:
> 
> Do you want me to remove MSVS_VERSION=="2005e"?
> 
> What about MSVS_VERSION=="2008e"?

Yes to both.

https://codereview.chromium.org/11933005/diff/1/testing/gtest.gyp
File testing/gtest.gyp (right):

https://codereview.chromium.org/11933005/diff/1/testing/gtest.gyp#newcode143
testing/gtest.gyp:143: ['OS=="win" and MSVS_VERSION=="2012e"', {
On 2013/01/20 01:14:38, wtc wrote:
> 
> I need help with this. Would this work?
> 
>   'OS=="win" and (MSVS_VERSION=="2012" or MSVS_VERSION=="2012e")'

Yes.

[wtc, 2013-01-23 03:42:26]

Please review patch set 2. Thanks.

[scottmg, 2013-01-23 16:38:57]

lgtm

[Mark Mentovai, 2013-01-23 16:55:23]

LGTM

[commit-bot: I haz the power, 2013-01-23 17:57:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wtc@chromium.org/11933005/5001

[commit-bot: I haz the power, 2013-01-23 20:32:53]

Change committed as 178369