Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(697)

Side by Side Diff: net/url_request/url_request_job_factory.h

Issue 11931024: Removed static factories for data, ftp, file, and about jobs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: sync (r198785) Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « net/url_request/url_request_http_job.cc ('k') | net/url_request/url_request_job_factory.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NET_URL_REQUEST_URL_REQUEST_JOB_FACTORY_H_ 5 #ifndef NET_URL_REQUEST_URL_REQUEST_JOB_FACTORY_H_
6 #define NET_URL_REQUEST_URL_REQUEST_JOB_FACTORY_H_ 6 #define NET_URL_REQUEST_URL_REQUEST_JOB_FACTORY_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 12 matching lines...) Expand all
23 class NET_EXPORT URLRequestJobFactory 23 class NET_EXPORT URLRequestJobFactory
24 : NON_EXPORTED_BASE(public base::NonThreadSafe) { 24 : NON_EXPORTED_BASE(public base::NonThreadSafe) {
25 public: 25 public:
26 // TODO(shalev): Move this to URLRequestJobFactoryImpl. 26 // TODO(shalev): Move this to URLRequestJobFactoryImpl.
27 class NET_EXPORT ProtocolHandler { 27 class NET_EXPORT ProtocolHandler {
28 public: 28 public:
29 virtual ~ProtocolHandler(); 29 virtual ~ProtocolHandler();
30 30
31 virtual URLRequestJob* MaybeCreateJob( 31 virtual URLRequestJob* MaybeCreateJob(
32 URLRequest* request, NetworkDelegate* network_delegate) const = 0; 32 URLRequest* request, NetworkDelegate* network_delegate) const = 0;
33
34 // Indicates if it should be safe to redirect to |location|. Should handle
35 // protocols handled by MaybeCreateJob(). Only called when registered with
36 // URLRequestJobFactoryImpl::SetProtocolHandler() not called when used with
37 // ProtocolInterceptJobFactory.
38 // NOTE(pauljensen): Default implementation returns true.
39 virtual bool IsSafeRedirectTarget(const GURL& location) const;
33 }; 40 };
34 41
35 URLRequestJobFactory(); 42 URLRequestJobFactory();
36 virtual ~URLRequestJobFactory(); 43 virtual ~URLRequestJobFactory();
37 44
38 virtual URLRequestJob* MaybeCreateJobWithProtocolHandler( 45 virtual URLRequestJob* MaybeCreateJobWithProtocolHandler(
39 const std::string& scheme, 46 const std::string& scheme,
40 URLRequest* request, 47 URLRequest* request,
41 NetworkDelegate* network_delegate) const = 0; 48 NetworkDelegate* network_delegate) const = 0;
42 49
43 virtual bool IsHandledProtocol(const std::string& scheme) const = 0; 50 virtual bool IsHandledProtocol(const std::string& scheme) const = 0;
44 51
45 virtual bool IsHandledURL(const GURL& url) const = 0; 52 virtual bool IsHandledURL(const GURL& url) const = 0;
46 53
54 virtual bool IsSafeRedirectTarget(const GURL& location) const = 0;
55
47 private: 56 private:
48 DISALLOW_COPY_AND_ASSIGN(URLRequestJobFactory); 57 DISALLOW_COPY_AND_ASSIGN(URLRequestJobFactory);
49 }; 58 };
50 59
51 } // namespace net 60 } // namespace net
52 61
53 #endif // NET_URL_REQUEST_URL_REQUEST_JOB_FACTORY_H_ 62 #endif // NET_URL_REQUEST_URL_REQUEST_JOB_FACTORY_H_
OLDNEW
« no previous file with comments | « net/url_request/url_request_http_job.cc ('k') | net/url_request/url_request_job_factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698