Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Side by Side Diff: net/url_request/url_request_about_job.cc

Issue 11931024: Removed static factories for data, ftp, file, and about jobs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: sync (r198785) Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « net/url_request/url_request_about_job.h ('k') | net/url_request/url_request_context.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Simple implementation of about: protocol handler that treats everything as 5 // Simple implementation of about: protocol handler that treats everything as
6 // about:blank. No other about: features should be available to web content, 6 // about:blank. No other about: features should be available to web content,
7 // so they're not implemented here. 7 // so they're not implemented here.
8 8
9 #include "net/url_request/url_request_about_job.h" 9 #include "net/url_request/url_request_about_job.h"
10 10
11 #include "base/bind.h" 11 #include "base/bind.h"
12 #include "base/compiler_specific.h" 12 #include "base/compiler_specific.h"
13 #include "base/message_loop.h" 13 #include "base/message_loop.h"
14 14
15 namespace net { 15 namespace net {
16 16
17 URLRequestAboutJob::URLRequestAboutJob(URLRequest* request, 17 URLRequestAboutJob::URLRequestAboutJob(URLRequest* request,
18 NetworkDelegate* network_delegate) 18 NetworkDelegate* network_delegate)
19 : URLRequestJob(request, network_delegate), 19 : URLRequestJob(request, network_delegate),
20 weak_factory_(this) { 20 weak_factory_(this) {
21 } 21 }
22 22
23 // static
24 URLRequestJob* URLRequestAboutJob::Factory(URLRequest* request,
25 NetworkDelegate* network_delegate,
26 const std::string& scheme) {
27 return new URLRequestAboutJob(request, network_delegate);
28 }
29
30 void URLRequestAboutJob::Start() { 23 void URLRequestAboutJob::Start() {
31 // Start reading asynchronously so that all error reporting and data 24 // Start reading asynchronously so that all error reporting and data
32 // callbacks happen as they would for network requests. 25 // callbacks happen as they would for network requests.
33 MessageLoop::current()->PostTask( 26 MessageLoop::current()->PostTask(
34 FROM_HERE, 27 FROM_HERE,
35 base::Bind(&URLRequestAboutJob::StartAsync, weak_factory_.GetWeakPtr())); 28 base::Bind(&URLRequestAboutJob::StartAsync, weak_factory_.GetWeakPtr()));
36 } 29 }
37 30
38 bool URLRequestAboutJob::GetMimeType(std::string* mime_type) const { 31 bool URLRequestAboutJob::GetMimeType(std::string* mime_type) const {
39 *mime_type = "text/html"; 32 *mime_type = "text/html";
40 return true; 33 return true;
41 } 34 }
42 35
43 URLRequestAboutJob::~URLRequestAboutJob() { 36 URLRequestAboutJob::~URLRequestAboutJob() {
44 } 37 }
45 38
46 void URLRequestAboutJob::StartAsync() { 39 void URLRequestAboutJob::StartAsync() {
47 NotifyHeadersComplete(); 40 NotifyHeadersComplete();
48 } 41 }
49 42
50 } // namespace net 43 } // namespace net
OLDNEW
« no previous file with comments | « net/url_request/url_request_about_job.h ('k') | net/url_request/url_request_context.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698