Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Unified Diff: tools/telemetry/telemetry/tracing_backend_unittest.py

Issue 11931015: Telemetry: fixes testGotTrace on old browsers. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/tracing_backend_unittest.py
diff --git a/tools/telemetry/telemetry/tracing_backend_unittest.py b/tools/telemetry/telemetry/tracing_backend_unittest.py
index 3146992a318acdc8e5a7d7d2506404559e89f726..f6817a1aa12d68e583b31aca5386c8562f220b93 100644
--- a/tools/telemetry/telemetry/tracing_backend_unittest.py
+++ b/tools/telemetry/telemetry/tracing_backend_unittest.py
@@ -4,6 +4,7 @@
import cStringIO
import json
+import logging
import os
import unittest
@@ -25,9 +26,11 @@ class TracingBackendTest(tab_test_case.TabTestCase):
util.WaitFor(_IsDone, 5)
def testGotTrace(self):
+ if not self._browser.supports_tracing:
+ logging.warning('Browser does not support tracing, skipping test.')
+ return
self._StartServer()
self._browser.StartTracing()
- self.assertTrue(self._browser.supports_tracing)
self._browser.StopTracing()
model = self._browser.GetTraceResultAndReset().AsTimelineModel()
events = model.GetAllEvents()
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698