Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Issue 11931011: Remove IBusUiController. (Closed)

Created:
7 years, 11 months ago by Seigo Nonaka
Modified:
7 years, 10 months ago
Reviewers:
satorux1
CC:
chromium-reviews, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org
Visibility:
Public.

Description

Remove IBusUiController. IBusUiController was used as adapter of ibus_panel_service in libibus. However libibus was gone and we can use ibus::IBusPanelCandidateWindowHandlerInterface instead. So it's time to remove IBusUiController. This patch should be submit after https://codereview.chromium.org/11956008/ BUG=None TEST=Manually done. TBR=jochen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=179841

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -291 lines) Patch
M chrome/browser/chromeos/input_method/candidate_view.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/candidate_window_controller_impl.h View 4 chunks +18 lines, -20 lines 0 comments Download
M chrome/browser/chromeos/input_method/candidate_window_controller_impl.cc View 1 9 chunks +19 lines, -17 lines 0 comments Download
M chrome/browser/chromeos/input_method/candidate_window_view.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/candidate_window_view.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
D chrome/browser/chromeos/input_method/ibus_ui_controller.h View 1 chunk +0 lines, -124 lines 0 comments Download
D chrome/browser/chromeos/input_method/ibus_ui_controller.cc View 1 chunk +0 lines, -124 lines 0 comments Download
M chrome/browser/chromeos/input_method/infolist_window_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Seigo Nonaka
7 years, 11 months ago (2013-01-16 07:03:46 UTC) #1
satorux1
LGTM
7 years, 11 months ago (2013-01-17 21:11:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/11931011/4001
7 years, 10 months ago (2013-01-31 05:28:05 UTC) #3
commit-bot: I haz the power
Presubmit check for 11931011-4001 failed and returned exit status 1. Running presubmit commit checks ...
7 years, 10 months ago (2013-01-31 05:28:09 UTC) #4
Seigo Nonaka
TBR-ing to jochen@chromium.org for gypi file. This just remove obsolete class.
7 years, 10 months ago (2013-01-31 06:25:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/11931011/4001
7 years, 10 months ago (2013-01-31 06:28:05 UTC) #6
commit-bot: I haz the power
7 years, 10 months ago (2013-01-31 10:23:43 UTC) #7
Message was sent while issue was closed.
Change committed as 179841

Powered by Google App Engine
This is Rietveld 408576698