Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(606)

Unified Diff: lib/mixin.dart

Issue 1192943003: changes for 0.3.9 (Closed) Base URL: https://github.com/dart-lang/dart-protoc-plugin.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/mixin.dart
diff --git a/lib/mixin.dart b/lib/mixin.dart
new file mode 100644
index 0000000000000000000000000000000000000000..0c55b23c8f35b884e42d29df1367062bbd7dbf04
--- /dev/null
+++ b/lib/mixin.dart
@@ -0,0 +1,11 @@
+// Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+part of protoc;
Siggi Cherem (dart-lang) 2015/06/22 19:38:57 might be worth renaming this file, maybe make it i
skybrian 2015/06/23 02:21:25 I replaced this file in favor of the mixins_meta l
+
+// Each supported mixin should have an entry in this map.
+// TODO: figure out how to extract the reserved names automatically.
Siggi Cherem (dart-lang) 2015/06/22 19:38:57 since protoc runs in the vm only, you could to do
skybrian 2015/06/23 02:21:26 Yes, but I'm not sure why we didn't do that before
+const reservedNamesForMixins = const {
+ "PbMapMixin": PbMapMixin_reservedNames,
Siggi Cherem (dart-lang) 2015/06/22 19:38:57 nit: unindent (indent only +2)
+};

Powered by Google App Engine
This is Rietveld 408576698