lib/mixin.dart - Issue 1192943003: changes for 0.3.9

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: lib/mixin.dart

Issue 1192943003: changes for 0.3.9 (Closed) Base URL: https://github.com/dart-lang/dart-protoc-plugin.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file

	2 // for details. All rights reserved. Use of this source code is governed by a

	3 // BSD-style license that can be found in the LICENSE file.

	4

	5 part of protoc;
	Siggi Cherem (dart-lang) 2015/06/22 19:38:57 might be worth renaming this file, maybe make it i might be worth renaming this file, maybe make it it's own library under lib/src/? For example, `lib/src/reserved_names.dart`. skybrian 2015/06/23 02:21:25 I replaced this file in favor of the mixins_meta l Show quoted text On 2015/06/22 19:38:57, Siggi Cherem (dart-lang) wrote: > might be worth renaming this file, maybe make it it's own library under > lib/src/? > > For example, `lib/src/reserved_names.dart`. I replaced this file in favor of the mixins_meta library in the protobuf package.
	6

	7 // Each supported mixin should have an entry in this map.

	8 // TODO: figure out how to extract the reserved names automatically.
	Siggi Cherem (dart-lang) 2015/06/22 19:38:57 since protoc runs in the vm only, you could to do since protoc runs in the vm only, you could to do automatically with mirrors. skybrian 2015/06/23 02:21:26 Yes, but I'm not sure why we didn't do that before Show quoted text On 2015/06/22 19:38:57, Siggi Cherem (dart-lang) wrote: > since protoc runs in the vm only, you could to do automatically with mirrors. Yes, but I'm not sure why we didn't do that before for the reserved names in GeneratedMessage, so I went with existing practice for now.
	9 const reservedNamesForMixins = const {

	10 "PbMapMixin": PbMapMixin_reservedNames,
	Siggi Cherem (dart-lang) 2015/06/22 19:38:57 nit: unindent (indent only +2) nit: unindent (indent only +2)
	11 };

OLD	NEW

« lib/message_generator.dart ('K') | « lib/message_generator.dart ('k') | lib/protoc.dart » ('j') | lib/src/dart_options.pb.dart » ('J')