Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(673)

Unified Diff: build/android/java_cpp_template.gypi

Issue 11929032: Fixed issue that the change of header file didn't rebuild the template file. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: sync Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/content.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/java_cpp_template.gypi
diff --git a/build/android/java_cpp_template.gypi b/build/android/java_cpp_template.gypi
index a222e15d7d46ec3ef5f9f95fc90b5e5db59fd803..3c5704ea3f7bf3c42657a8a9bb1c4fd8f3aa2642 100644
--- a/build/android/java_cpp_template.gypi
+++ b/build/android/java_cpp_template.gypi
@@ -14,21 +14,21 @@
# 'target_name': 'android_net_java_constants',
# 'type': 'none',
# 'sources': [
-# 'net/base/certificate_mime_type_list.h',
# 'net/android/NetError.template',
# ],
# 'variables': {
# 'package_name': 'org.chromium.net',
+# 'template_deps': ['net/base/certificate_mime_type_list.h'],
# },
# 'includes': [ '../build/android/java_constants.gypi' ],
# },
#
-# The 'sources' entry should list all input files. The template file
+# The 'sources' entry should only list template file. The template file
# itself should use the 'ClassName.template' format, and will generate
-# 'gen/templates/<package-name>/ClassName.java. Other source files
-# are those typically included by the template. Any change to them
-# will force a rebuild of the template, and hence of any source that
-# depends on it.
+# 'gen/templates/<package-name>/ClassName.java. The files which template
+# dependents on and typically included by the template should be listed
+# in template_deps variables. Any change to them will force a rebuild of
+# the template, and hence of any source that depends on it.
#
{
@@ -51,9 +51,8 @@
{
'rule_name': 'generate_java_constants',
'extension': 'template',
- 'inputs': [
- '<(RULE_INPUT_PATH)',
- ],
+ # Set template_deps as additional dependencies.
+ 'inputs': ['<@(template_deps)'],
'outputs': [
'<(output_dir)/<(RULE_INPUT_ROOT).java'
],
« no previous file with comments | « no previous file | content/content.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698