Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11929032: Fixed issue that the change of header file didn't rebuild the template file. (Closed)

Created:
7 years, 11 months ago by michaelbai
Modified:
7 years, 11 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, jam, joi+watch-content_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, darin-cc_chromium.org, klundberg+watch_chromium.org, ilevy+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

Fixed issue that the change of header file didn't rebuild the template file. Previous one didn't work because only change files whose extension is same as rule's extension will make the target rebuild. BUG=170995 TBR=jam,agl Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177825

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : revert the copyright change #

Patch Set 4 : sync #

Patch Set 5 : sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -12 lines) Patch
M build/android/java_cpp_template.gypi View 1 2 2 chunks +8 lines, -9 lines 0 comments Download
M content/content.gyp View 1 chunk +1 line, -1 line 0 comments Download
M net/net.gyp View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
michaelbai
7 years, 11 months ago (2013-01-18 21:31:41 UTC) #1
mkosiba (inactive)
https://codereview.chromium.org/11929032/diff/3001/build/android/java_cpp_template.gypi File build/android/java_cpp_template.gypi (right): https://codereview.chromium.org/11929032/diff/3001/build/android/java_cpp_template.gypi#newcode1 build/android/java_cpp_template.gypi:1: # Copyright (c) 2013 The Chromium Authors. All rights ...
7 years, 11 months ago (2013-01-18 21:44:38 UTC) #2
Torne
LGTM % martin's comment (we do indeed leave copyrights alone now)
7 years, 11 months ago (2013-01-18 21:46:39 UTC) #3
michaelbai
https://codereview.chromium.org/11929032/diff/3001/build/android/java_cpp_template.gypi File build/android/java_cpp_template.gypi (right): https://codereview.chromium.org/11929032/diff/3001/build/android/java_cpp_template.gypi#newcode1 build/android/java_cpp_template.gypi:1: # Copyright (c) 2013 The Chromium Authors. All rights ...
7 years, 11 months ago (2013-01-18 21:50:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/michaelbai@chromium.org/11929032/6001
7 years, 11 months ago (2013-01-18 22:00:03 UTC) #5
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 11 months ago (2013-01-18 22:22:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/michaelbai@chromium.org/11929032/5
7 years, 11 months ago (2013-01-18 23:32:18 UTC) #7
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 11 months ago (2013-01-18 23:55:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/michaelbai@chromium.org/11929032/6006
7 years, 11 months ago (2013-01-19 00:52:13 UTC) #9
commit-bot: I haz the power
Change committed as 177825
7 years, 11 months ago (2013-01-19 04:05:49 UTC) #10
digit1
7 years, 11 months ago (2013-01-21 09:28:03 UTC) #11
Message was sent while issue was closed. 
Nice, thanks for doing this.

Powered by Google App Engine
This is Rietveld 408576698