Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11929016: Move jstemplate_builder.* to ui\webui so it can be reused by webui implementations outside of chrom… (Closed)

Created:
7 years, 11 months ago by jam
Modified:
7 years, 11 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, dbeam+watch-options_chromium.org, dbeam+watch-ntp_chromium.org, cbentzel+watch_chromium.org, nkostylev+watch_chromium.org, feature-media-reviews_chromium.org, pam+watch_chromium.org, oshima+watch_chromium.org, darin-cc_chromium.org, estade+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, pedrosimonetti+watch_chromium.org
Visibility:
Public.

Description

Move jstemplate_builder.* to ui\webui so it can be reused by webui implementations outside of chrome. BUG=169170 TBR=estade Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177729

Patch Set 1 #

Patch Set 2 : magic resource fix #

Patch Set 3 : #

Patch Set 4 : sync to 177705 to get yfriendman's fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -305 lines) Patch
M chrome/app/chrome_main_delegate.cc View 1 2 3 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/chrome_browser_main.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 2 3 2 chunks +8 lines, -1 line 0 comments Download
M chrome/browser/chromeos/offline/offline_load_page.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/managed_mode/managed_mode_interstitial.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/managed_mode/managed_mode_navigation_observer.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/printing/cloud_print/cloud_print_setup_source.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_blocking_page.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ssl/ssl_blocking_page.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/pdf/pdf_unsupported_feature.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/about_ui.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chrome_web_ui_data_source.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chrome_web_ui_data_source_unittest.cc View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/choose_mobile_network_ui.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/oobe_ui.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/mobile_setup_ui.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/proxy_settings_ui.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/sim_unlock_ui.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/system_info_ui.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/media/media_internals_ui.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/ntp/ntp_resource_cache.cc View 1 2 3 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/ui/webui/ntp/ntp_resource_cache_android.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/options_ui.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/tab_modal_confirm_dialog_webui.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/version_ui.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_common.gypi View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/common_resources.grd View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/descriptors_android.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
D chrome/common/jstemplate_builder.h View 1 2 3 1 chunk +0 lines, -86 lines 0 comments Download
D chrome/common/jstemplate_builder.cc View 1 2 3 1 chunk +0 lines, -156 lines 0 comments Download
M chrome/common/net/net_resource_provider.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/renderer/plugins/plugin_placeholder.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M ui/ui.gyp View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
A ui/webui/DEPS View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
A + ui/webui/jstemplate_builder.h View 3 chunks +23 lines, -19 lines 0 comments Download
A + ui/webui/jstemplate_builder.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M ui/webui/resources/webui_resources.grd View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jam
7 years, 11 months ago (2013-01-18 17:11:18 UTC) #1
Evan Stade
7 years, 11 months ago (2013-01-18 22:58:39 UTC) #2
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698