Updated the look of web and basic notifications to match latest mockups.

Updated the look of web and basic notifications to match latest mockups.

This was done by having all notification types display themselves using
the NotificationView class that was previously only used for image and
list notifications. This class already supported the new look and
already worked for notifications that had neither images nor lists.

BUG=168729
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=178381

[dharcourt, 2013-01-19 03:06:13]

Mike, for you to LGTM when you're satisfied with the code.

Jun, feel free to pitch in with suggestions and I won't commit without adressing
them.

Thanks for the review!

    - Charles

https://codereview.chromium.org/11926032/diff/1/ui/message_center/base_format...
File ui/message_center/base_format_view.cc (left):

https://codereview.chromium.org/11926032/diff/1/ui/message_center/base_format...
ui/message_center/base_format_view.cc:202: }  // namespace message_center
BaseFormatView replaced by NotificationView.

https://codereview.chromium.org/11926032/diff/1/ui/message_center/base_format...
File ui/message_center/base_format_view.h (left):

https://codereview.chromium.org/11926032/diff/1/ui/message_center/base_format...
ui/message_center/base_format_view.h:43: #endif  //
UI_MESSAGE_CENTER_BASE_FORMAT_VIEW_H_
BaseFormatView replaced by NotificationView.

https://codereview.chromium.org/11926032/diff/1/ui/message_center/message_sim...
File ui/message_center/message_simple_view.cc (left):

https://codereview.chromium.org/11926032/diff/1/ui/message_center/message_sim...
ui/message_center/message_simple_view.cc:95: }  // namespace message_center
MessageSimpleView replaced by NotificationView.

https://codereview.chromium.org/11926032/diff/1/ui/message_center/message_sim...
File ui/message_center/message_simple_view.h (left):

https://codereview.chromium.org/11926032/diff/1/ui/message_center/message_sim...
ui/message_center/message_simple_view.h:31: #endif //
UI_MESSAGE_CENTER_MESSAGE_SIMPLE_VIEW_H_
MessageSimpleView replaced by NotificationView.

https://codereview.chromium.org/11926032/diff/1/ui/message_center/message_vie...
File ui/message_center/message_view_factory.cc (left):

https://codereview.chromium.org/11926032/diff/1/ui/message_center/message_vie...
ui/message_center/message_view_factory.cc:43: }  // namespace message_center
MessageViewFactory replaced by a class method in NotificationView.

https://codereview.chromium.org/11926032/diff/1/ui/message_center/message_vie...
File ui/message_center/message_view_factory.h (left):

https://codereview.chromium.org/11926032/diff/1/ui/message_center/message_vie...
ui/message_center/message_view_factory.h:26: #endif  //
UI_MESSAGE_CENTER_WEB_MESSAGE_VIEW_FACTORY_H_
MessageViewFactory replaced by a class method in NotificationView.

[miket_OOO, 2013-01-22 22:39:18]

lgtm

https://chromiumcodereview.appspot.com/11926032/diff/1/ui/message_center/noti...
File ui/message_center/notification_view.cc (right):

https://chromiumcodereview.appspot.com/11926032/diff/1/ui/message_center/noti...
ui/message_center/notification_view.cc:180: }
Vertical whitespace after this line would make it easier to read.

[dharcourt, 2013-01-23 08:10:12]

https://codereview.chromium.org/11926032/diff/1/ui/message_center/notificatio...
File ui/message_center/notification_view.cc (right):

https://codereview.chromium.org/11926032/diff/1/ui/message_center/notificatio...
ui/message_center/notification_view.cc:180: }
On 2013/01/22 22:39:18, miket wrote:
> Vertical whitespace after this line would make it easier to read.

Done.

[commit-bot: I haz the power, 2013-01-23 19:08:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dharcourt@chromium.org/11926032/5001

[commit-bot: I haz the power, 2013-01-23 21:15:36]

Change committed as 178381