Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(706)

Unified Diff: runtime/vm/stack_frame.h

Issue 1192103004: VM: New calling convention for generated code. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: ARM64 port Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/stack_frame.h
diff --git a/runtime/vm/stack_frame.h b/runtime/vm/stack_frame.h
index 94ba9d31837e3fdcd98ae4b278df180be3530ec7..b2bffd74f497e3cf8c662894bb5318cb306581be 100644
--- a/runtime/vm/stack_frame.h
+++ b/runtime/vm/stack_frame.h
@@ -50,7 +50,11 @@ class StackFrame : public ValueObject {
}
void set_pc(uword value) {
- *reinterpret_cast<uword*>(sp_ + (kSavedPcSlotFromSp * kWordSize)) = value;
+ *reinterpret_cast<uword*>(sp() + (kSavedPcSlotFromSp * kWordSize)) = value;
+ }
+
+ void set_pc_marker(uword value) {
koda 2015/09/11 13:22:05 Since this slot is traversed by GC, shouldn't this
Florian Schneider 2015/09/11 14:30:23 Done. (and yes, I'm not done with renaming pc-mark
+ *reinterpret_cast<uword*>(fp() + (kPcMarkerSlotFromFp * kWordSize)) = value;
}
// Visit objects in the frame.

Powered by Google App Engine
This is Rietveld 408576698