VM: New calling convention for generated code.

runtime/vm/stack_frame.h

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_STACK_FRAME_H_
 #define VM_STACK_FRAME_H_
 
 #include "vm/allocation.h"
 #include "vm/object.h"
 #include "vm/stub_code.h"
@@ skipping 32 matching lines @@
   // The pool pointer is not implemented on all architectures.
   static int SavedCallerPpSlotFromFp() {
     if (kSavedCallerPpSlotFromFp != kSavedCallerFpSlotFromFp) {
       return kSavedCallerPpSlotFromFp;
     }
     UNREACHABLE();
     return 0;
   }
 
   void set_pc(uword value) {
-    *reinterpret_cast<uword*>(sp_ + (kSavedPcSlotFromSp * kWordSize)) = value;
+    *reinterpret_cast<uword*>(sp() + (kSavedPcSlotFromSp * kWordSize)) = value;
+  }
+
+  void set_pc_marker(uword value) {

[koda, 2015/09/11 13:22:05]

Since this slot is traversed by GC, shouldn't this interface take a RawObject*
(or RawCode*)?

[Florian Schneider, 2015/09/11 14:30:23]

Done. (and yes, I'm not done with renaming pc-marker yet... for now everything
named pc-marker just contains a RawCode object)

+    *reinterpret_cast<uword*>(fp() + (kPcMarkerSlotFromFp * kWordSize)) = value;
   }
 
   // Visit objects in the frame.
   virtual void VisitObjectPointers(ObjectPointerVisitor* visitor);
 
   const char* ToCString() const;
 
   // Check validity of a frame, used for assertion purposes.
   virtual bool IsValid() const;
 
@@ skipping 260 matching lines @@
   uword pc_;
   GrowableArray<DeoptInstr*> deopt_instructions_;
   ObjectPool& object_table_;
 
   DISALLOW_COPY_AND_ASSIGN(InlinedFunctionsIterator);
 };
 
 }  // namespace dart
 
 #endif  // VM_STACK_FRAME_H_