Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 11914003: Start sending synthetic keyevents for enter and tab in Android IME (Closed)

Created:
7 years, 11 months ago by Yusuf
Modified:
7 years, 11 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Start sending synthetic keyevents for enter and tab in Android IME After sdk 15 Android framework no longer sends keyevents for enter and tab and the current spec says the dispatchKeyEvent call should only be used for hardware keyboard. So we stop calling ImeAdapter with dispathKeyEvent if the keyboard is not connected and also start sending these keyevents when a they are committed as a single character BUG=166233 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177774

Patch Set 1 #

Total comments: 8

Patch Set 2 : Nit fixes #

Patch Set 3 : Added call to performEditorAction #

Total comments: 8

Patch Set 4 : Nit fixes #

Patch Set 5 : Added another shortcircuit for IMEs that send KeyEvents #

Patch Set 6 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -50 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 1 2 3 4 5 2 chunks +8 lines, -11 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ImeAdapter.java View 1 2 3 4 5 8 chunks +44 lines, -39 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Yusuf
7 years, 11 months ago (2013-01-15 21:00:14 UTC) #1
aurimas (slooooooooow)
lgtm with small nits https://codereview.chromium.org/11914003/diff/1/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java File content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java (right): https://codereview.chromium.org/11914003/diff/1/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java#newcode1419 content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java:1419: && (mKeyboardConnected && mImeAdapter.dispatchKeyEvent(event))) Could ...
7 years, 11 months ago (2013-01-16 00:39:57 UTC) #2
Ted C
lgtm w/ Aurimas's suggestions https://codereview.chromium.org/11914003/diff/1/content/public/android/java/src/org/chromium/content/browser/ImeAdapter.java File content/public/android/java/src/org/chromium/content/browser/ImeAdapter.java (right): https://codereview.chromium.org/11914003/diff/1/content/public/android/java/src/org/chromium/content/browser/ImeAdapter.java#newcode344 content/public/android/java/src/org/chromium/content/browser/ImeAdapter.java:344: timeStampMs, keyCode, keyChar); previously this ...
7 years, 11 months ago (2013-01-16 02:13:30 UTC) #3
Yusuf
https://codereview.chromium.org/11914003/diff/1/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java File content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java (right): https://codereview.chromium.org/11914003/diff/1/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java#newcode1419 content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java:1419: && (mKeyboardConnected && mImeAdapter.dispatchKeyEvent(event))) On 2013/01/16 00:39:57, aurimas wrote: ...
7 years, 11 months ago (2013-01-16 08:07:57 UTC) #4
Yusuf
I had to modify this a little bit since I realized the change was goign ...
7 years, 11 months ago (2013-01-16 22:29:44 UTC) #5
Ted C
https://codereview.chromium.org/11914003/diff/9001/content/public/android/java/src/org/chromium/content/browser/ImeAdapter.java File content/public/android/java/src/org/chromium/content/browser/ImeAdapter.java (right): https://codereview.chromium.org/11914003/diff/9001/content/public/android/java/src/org/chromium/content/browser/ImeAdapter.java#newcode363 content/public/android/java/src/org/chromium/content/browser/ImeAdapter.java:363: private void sendKeyEventWithKeyCode(int KeyCode, int flags) { s/KeyCode/keyCode https://codereview.chromium.org/11914003/diff/9001/content/public/android/java/src/org/chromium/content/browser/ImeAdapter.java#newcode609 ...
7 years, 11 months ago (2013-01-16 23:48:57 UTC) #6
aurimas (slooooooooow)
https://codereview.chromium.org/11914003/diff/9001/content/public/android/java/src/org/chromium/content/browser/ImeAdapter.java File content/public/android/java/src/org/chromium/content/browser/ImeAdapter.java (right): https://codereview.chromium.org/11914003/diff/9001/content/public/android/java/src/org/chromium/content/browser/ImeAdapter.java#newcode33 content/public/android/java/src/org/chromium/content/browser/ImeAdapter.java:33: // a) If a key event has been recorded ...
7 years, 11 months ago (2013-01-16 23:54:45 UTC) #7
Yusuf
https://codereview.chromium.org/11914003/diff/9001/content/public/android/java/src/org/chromium/content/browser/ImeAdapter.java File content/public/android/java/src/org/chromium/content/browser/ImeAdapter.java (right): https://codereview.chromium.org/11914003/diff/9001/content/public/android/java/src/org/chromium/content/browser/ImeAdapter.java#newcode33 content/public/android/java/src/org/chromium/content/browser/ImeAdapter.java:33: // a) If a key event has been recorded ...
7 years, 11 months ago (2013-01-17 00:44:19 UTC) #8
Yusuf
Added another shortcircuit mechanism that makes sendKeyEvent in AdapterInputConnection work if the IME sends a ...
7 years, 11 months ago (2013-01-17 01:42:29 UTC) #9
aurimas (slooooooooow)
lgtm
7 years, 11 months ago (2013-01-17 23:36:18 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusufo@chromium.org/11914003/17001
7 years, 11 months ago (2013-01-18 02:52:14 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusufo@chromium.org/11914003/17001
7 years, 11 months ago (2013-01-18 21:34:46 UTC) #12
commit-bot: I haz the power
7 years, 11 months ago (2013-01-18 22:22:34 UTC) #13
Message was sent while issue was closed.
Change committed as 177774

Powered by Google App Engine
This is Rietveld 408576698