Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Issue 11910005: Add additional error handling and null checking to ImageSkiaOperations (Closed)

Created:
7 years, 11 months ago by pkotwicz
Modified:
7 years, 11 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, rsesek+watch_chromium.org
Visibility:
Public.

Description

Add additional error handling and null checking to ImageSkiaOperations BUG=167788 Test=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177210

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Fix browser_tests failures #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -10 lines) Patch
M ui/gfx/image/image_skia_operations.cc View 1 2 14 chunks +63 lines, -7 lines 0 comments Download
M ui/gfx/image/image_skia_rep.h View 2 chunks +4 lines, -1 line 0 comments Download
M ui/gfx/image/image_skia_rep.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
pkotwicz
rsesek can you please take a look?
7 years, 11 months ago (2013-01-15 19:36:54 UTC) #1
Robert Sesek
LGTM
7 years, 11 months ago (2013-01-15 20:41:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/11910005/2001
7 years, 11 months ago (2013-01-16 00:39:59 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests
7 years, 11 months ago (2013-01-16 03:39:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/11910005/14002
7 years, 11 months ago (2013-01-16 16:50:52 UTC) #5
commit-bot: I haz the power
7 years, 11 months ago (2013-01-16 20:35:52 UTC) #6
Message was sent while issue was closed.
Change committed as 177210

Powered by Google App Engine
This is Rietveld 408576698